Paths

Table of Contentst

Differential D778

Explicitely log exception message
ClosedPublic
Actions

Authored by dereckson on Dec 30 2016, 02:11.

Tags

None

Referenced Files

	F3909572: D778.diff
	Wed, Dec 18, 20:38

	Unknown Object (File)
	Tue, Dec 17, 04:45

	Unknown Object (File)
	Tue, Dec 10, 02:58

	Unknown Object (File)
	Tue, Dec 10, 02:31

	Unknown Object (File)
	Fri, Dec 6, 23:50

	Unknown Object (File)
	Tue, Dec 3, 18:02

	Unknown Object (File)
	Thu, Nov 28, 09:32

	Unknown Object (File)
	Thu, Nov 28, 07:18

Subscribers

Details

Reviewers

Commits

rNOTIF905274bef2a3: Explicitely log exception message

Summary

The notifications center logs exceptions thrown's messages,
and to do so pass the exception to the log method.

As this method wants a string as parameter, it was converted as string.
But as we plan to use declare(strict_types=1), such implicit conver-
sion isn't welcome.

Fixes the following issue detected by phan:

app/Exceptions/Handler.php:49
PhanTypeMismatchArgument
Argument 1 (message) is \Exception|\Throwable but
\Psr\Log\LoggerInterface::error() takes string defined at
vendor/psr/log/Psr/Log/LoggerInterface.php:66

Test Plan

phan | grep PhanTypeMismatchArgument

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Tests Passed

Branch

explicit-string-type (branched from master)

Event Timeline

dereckson created this revision.Dec 30 2016, 02:11

Build is green https://ci.nasqueron.org/job/test-notifications-phab/241/ for more details.

Call magic method instead of only the message.

dereckson planned changes to this revision.Dec 30 2016, 02:19

dereckson added inline comments.

app/Exceptions/Handler.php
49	http://php.net/manual/en/exception.tostring.php We're losing information here. `(string)$e` or `$e->__toString()` would allow to keep it.

dereckson accepted this revision.Dec 30 2016, 02:19

dereckson requested a review of this revision.

dereckson edited edge metadata.

dereckson marked an inline comment as done.

This revision is now accepted and ready to land.Dec 30 2016, 02:19

Closed by commit rNOTIF905274bef2a3: Explicitely log exception message (authored by dereckson, committed by dereckson). · Explain WhyDec 30 2016, 02:21

This revision was automatically updated to reflect the committed changes.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/242/ for more details.

Revision Contents
Changeset List

Path

Size

app/

Exceptions/

2 lines

Diff 1969

app/Exceptions/Handler.php

Loading...