Page MenuHomeDevCentral

Explicitely log exception message
ClosedPublic

Authored by dereckson on Dec 30 2016, 02:11.
Tags
None
Referenced Files
F10404361: D778.diff
Sat, Jul 5, 11:45
Unknown Object (File)
Thu, Jul 3, 04:04
Unknown Object (File)
Wed, Jul 2, 06:45
Unknown Object (File)
Mon, Jun 30, 09:14
Unknown Object (File)
Sat, Jun 28, 05:41
Unknown Object (File)
Thu, Jun 26, 13:47
Unknown Object (File)
Mon, Jun 23, 15:43
Unknown Object (File)
Sun, Jun 22, 15:14
Subscribers

Details

Summary

The notifications center logs exceptions thrown's messages,
and to do so pass the exception to the log method.

As this method wants a string as parameter, it was converted as string.
But as we plan to use declare(strict_types=1), such implicit conver-
sion isn't welcome.

Fixes the following issue detected by phan:

app/Exceptions/Handler.php:49
PhanTypeMismatchArgument
Argument 1 (message) is \Exception|\Throwable but
\Psr\Log\LoggerInterface::error() takes string defined at
vendor/psr/log/Psr/Log/LoggerInterface.php:66
Test Plan

phan | grep PhanTypeMismatchArgument

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
explicit-string-type (branched from master)

Event Timeline

dereckson edited edge metadata.

Call magic method instead of only the message.

dereckson added inline comments.
app/Exceptions/Handler.php
49

http://php.net/manual/en/exception.tostring.php

We're losing information here.

(string)$e or $e->__toString() would allow to keep it.

dereckson requested a review of this revision.
dereckson edited edge metadata.
dereckson marked an inline comment as done.
This revision is now accepted and ready to land.Dec 30 2016, 02:19
This revision was automatically updated to reflect the committed changes.