Page MenuHomeDevCentral

Explicitely log exception message
ClosedPublic

Authored by dereckson on Dec 30 2016, 02:11.
Tags
None
Referenced Files
F11723478: D778.diff
Tue, Sep 16, 10:25
Unknown Object (File)
Mon, Sep 15, 08:10
Unknown Object (File)
Sun, Sep 14, 11:03
Unknown Object (File)
Sun, Sep 14, 11:03
Unknown Object (File)
Sun, Sep 14, 10:54
Unknown Object (File)
Sat, Sep 13, 16:00
Unknown Object (File)
Fri, Sep 12, 22:17
Unknown Object (File)
Fri, Sep 12, 22:17
Subscribers

Details

Summary

The notifications center logs exceptions thrown's messages,
and to do so pass the exception to the log method.

As this method wants a string as parameter, it was converted as string.
But as we plan to use declare(strict_types=1), such implicit conver-
sion isn't welcome.

Fixes the following issue detected by phan:

app/Exceptions/Handler.php:49
PhanTypeMismatchArgument
Argument 1 (message) is \Exception|\Throwable but
\Psr\Log\LoggerInterface::error() takes string defined at
vendor/psr/log/Psr/Log/LoggerInterface.php:66
Test Plan

phan | grep PhanTypeMismatchArgument

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson edited edge metadata.

Call magic method instead of only the message.

dereckson added inline comments.
app/Exceptions/Handler.php
49

http://php.net/manual/en/exception.tostring.php

We're losing information here.

(string)$e or $e->__toString() would allow to keep it.

dereckson requested a review of this revision.
dereckson edited edge metadata.
dereckson marked an inline comment as done.
This revision is now accepted and ready to land.Dec 30 2016, 02:19
This revision was automatically updated to reflect the committed changes.