Page MenuHomeDevCentral
Differential D829

Compute Twitter text of status update length with t.co link wrapping
ClosedPublic
Actions

Authored by dereckson on Jan 13 2017, 09:57.
Tags
None
Referenced Files
F3925544: D829.id2107.diff
Sat, Dec 21, 18:50
F3925516: D829.id2102.diff
Sat, Dec 21, 18:48
F3925515: D829.id2101.diff
Sat, Dec 21, 18:48
F3925514: D829.id2100.diff
Sat, Dec 21, 18:48
F3925513: D829.id2099.diff
Sat, Dec 21, 18:48
F3925131: D829.id.diff
Sat, Dec 21, 17:29
F3924903: D829.diff
Sat, Dec 21, 16:05
Unknown Object (File)
Sat, Dec 21, 14:55
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rVIPER8d5a1eb3aed0: Compute Twitter text of status update length with t.co link wrapping
Summary

Twitter replaces links by t.co links.

As such, links are currently counted as 23 characters.
This link size is dynamic and we fetch it from configuraiton

New commands:
'.twitter reconfigure' refreshes the link size

New behavior:
Commands like !pub !idée counts links size correctly

New registry variables:

  • twitter.short_url_length: the cached link length
  • twitter.default_account: the account used for /help/configuration API calls

Reference:

Test Plan

Unit tests have been added for the URL links count.

.twitter reconfigure has been tested on Dæghrefn:

.tcl registry set twitter.short_url_length 1000
Tcl:
.tcl twitter_get_short_url_length
Tcl: 1000
.twitter reconfigure
[09:49:16] #Dereckson# twitter reconfigure
.tcl twitter_get_short_url_length
Tcl: 23

Diff Detail

Repository
rVIPER ViperServ scripts
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
master
Build Status
Buildable 1271
Build 1519: arc lint + arc unit

Event Timeline

dereckson created this revision.Jan 13 2017, 09:57
dereckson planned changes to this revision.Jan 13 2017, 10:05
dereckson added inline comments.
Daeghrefn/Communication.tcl
402

tweet

dereckson updated this revision to Diff 2100.Jan 13 2017, 10:06
dereckson marked an inline comment as done.
dereckson edited edge metadata.

Fix typo in code comment

dereckson updated this revision to Diff 2101.Jan 13 2017, 10:59

Add !StyleEncyclo command

The account https://twitter.com/StyleEncyclo provides a best of articles
where the style doesn't follow the Wikipedia conventions.

The account is managed by Ælfgar.
@Raminagrobis suggested to allow to publish from IRC like !idée.

Harbormaster completed remote builds in B1272: Diff 2101.Jan 13 2017, 10:59
dereckson updated this revision to Diff 2102.Jan 13 2017, 11:02

Reverted to diff 2100.

Harbormaster completed remote builds in B1273: Diff 2102.Jan 13 2017, 11:02
dereckson accepted this revision.Jan 13 2017, 11:02
This revision is now accepted and ready to land.Jan 13 2017, 11:02
dereckson added a parent revision: D830: Add !StyleEncyclo command.Jan 13 2017, 11:05
dereckson mentioned this in D830: Add !StyleEncyclo command.Jan 13 2017, 11:13
dereckson removed a parent revision: D830: Add !StyleEncyclo command.Jan 13 2017, 11:37
dereckson added a child revision: D830: Add !StyleEncyclo command.
Closed by commit rVIPER8d5a1eb3aed0: Compute Twitter text of status update length with t.co link wrapping (authored by dereckson, committed by dereckson). · Explain WhyJan 13 2017, 11:38
This revision was automatically updated to reflect the committed changes.
dereckson added a comment.Jan 16 2017, 06:14

Another test, post merge

150 characters status update
06:11:28 < Dereckson> !idée RFC 5785 via http://www.bortzmeyer.org/5785.html et
                      https://hueniverse.com/2009/11/23/host-meta-aka-site-meta-and-well-known-uris/ (auteur de la RFC)

Works like a charm at https://twitter.com/Ideedarticles/status/820876106916130816

Revision Contents
Changeset List

PathSize
Daeghrefn/
39 lines
tests/
40 lines
5 lines

Diff 2100

View Options

Daeghrefn/Communication.tcl

Loading...
View Options

tests/Communication.test

Loading...
View Options

tests/init.tcl

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator