Page MenuHomeDevCentral
Differential D814

Analyse The Guardian
ClosedPublic
Actions

Authored by Thibaut120094 on Jan 10 2017, 09:10.
Tags
None
Referenced Files
F24164865: D814.diff
Tue, Feb 10, 20:54
F24153530: D814.diff
Tue, Feb 10, 13:59
F24153527: D814.id2111.diff
Tue, Feb 10, 13:59
Unknown Object (File)
Fri, Feb 6, 13:48
Unknown Object (File)
Thu, Feb 5, 07:14
Unknown Object (File)
Wed, Feb 4, 20:42
Unknown Object (File)
Tue, Feb 3, 22:10
Unknown Object (File)
Sat, Jan 31, 11:58
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T1097: Analyze The Guardian
Commits
rSTGf066af3603f4: Analyse The Guardian
Summary

Fixes T1097.

Test Plan

https://www.theguardian.com/us-news/2016/nov/17/hillary-clinton-first-public-appearance-bernie-sanders

Diff Detail

Repository
rSTG Source templates generator
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
arcpatch-D814
Build Status
Buildable 1279
Build 1527: arc lint + arc unit

Event Timeline

Thibaut120094 created this revision.Jan 10 2017, 09:10
Harbormaster completed remote builds in B1249: Diff 2066.Jan 10 2017, 09:10
dereckson updated this revision to Diff 2073.Jan 11 2017, 04:56
dereckson edited edge metadata.

Expand tab to spaces

dereckson edited the test plan for this revision. (Show Details)Jan 11 2017, 04:59
dereckson added a task: T1097: Analyze The Guardian.Jan 11 2017, 05:19
dereckson edited the summary of this revision. (Show Details)
dereckson added a comment.Jan 11 2017, 06:50

Looks good, but as long as T1091 isn't solved, to use http://www.theguardian.com isn't useful, as The Guardian web server now rewrites URL to https.

dereckson requested changes to this revision.Jan 11 2017, 06:50
dereckson added inline comments.
pages/index.dat
27

Probably best to use https:// here, or to solve T1091 first.

This revision now requires changes to proceed.Jan 11 2017, 06:50
dereckson updated this revision to Diff 2111.Jan 13 2017, 17:09
dereckson edited edge metadata.

+https in pages/index.dat

dereckson accepted this revision.Jan 13 2017, 17:09
This revision is now accepted and ready to land.Jan 13 2017, 17:09
Closed by commit rSTGf066af3603f4: Analyse The Guardian (authored by Thibaut120094, committed by dereckson). · Explain WhyJan 13 2017, 17:10
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
pages/
2 lines
23 lines

Diff 2111

View Options

pages/index.dat

Loading...
View Options

pages/theguardian.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator