Page MenuHomeDevCentral

Locale set to en_US.UTF-8
ClosedPublic

Authored by dereckson on Dec 1 2015, 08:46.
Referenced Files
Unknown Object (File)
Thu, Dec 19, 21:19
Unknown Object (File)
Sat, Dec 14, 06:56
Unknown Object (File)
Sat, Dec 14, 04:54
Unknown Object (File)
Thu, Dec 12, 12:46
Unknown Object (File)
Thu, Dec 5, 18:37
Unknown Object (File)
Thu, Dec 5, 08:43
Unknown Object (File)
Sun, Nov 24, 10:02
Unknown Object (File)
Nov 16 2024, 08:55

Details

Summary

If a commit contains an UTF-8 character like → (right arrow),
Arcanist mangles it when using arc diff.

We install the locales package and fix the locale to en_US.UTF-8.

Reference: http://serverfault.com/a/689947/186660 by EirikW

Fixes T611.

Test Plan

Type an é in a shell launched in the container.

To launch it, arc shell or docker run --rm -it nasqueron/arcanist bash.

Diff Detail

Repository
rDARC nasqueron/arcanist Docker image
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
T611
Build Status
Buildable 111
Build 111: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to Locale set to en_US.UTF-8.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: Sandlayth.

Another test done: this diff has been created with an image built with this change, the from the commit were correctly printed and I were able to write an é.

I wonder if that shouldn't go to nasqueron/php-cli.

Sandlayth edited edge metadata.
This revision is now accepted and ready to land.Dec 2 2015, 09:24
This revision was automatically updated to reflect the committed changes.