Paths

Table of Contentst

Differential D101

Locale set to en_US.UTF-8
ClosedPublic
Actions

Authored by dereckson on Dec 1 2015, 08:46.

Tags

Referenced Files

	F12250888: D101.id229.diff
	Sat, Oct 11, 23:35

	F12249488: D101.diff
	Sat, Oct 11, 17:12

	Unknown Object (File)
	Fri, Oct 10, 00:53

	Unknown Object (File)
	Wed, Oct 8, 14:16

	Unknown Object (File)
	Thu, Oct 2, 16:24

	Unknown Object (File)
	Wed, Oct 1, 04:58

	Unknown Object (File)
	Sun, Sep 28, 07:22

	Unknown Object (File)
	Sat, Sep 27, 10:00

Subscribers

Nasqueron Docker deployment squad

Details

Reviewers

Maniphest Tasks

T611: nasqueron/arcanist isn't UTF-8 compliant

Commits

rDARC7ee6ff557e49: Locale set to en_US.UTF-8

Summary

If a commit contains an UTF-8 character like → (right arrow),
Arcanist mangles it when using arc diff.

We install the locales package and fix the locale to en_US.UTF-8.

Reference: http://serverfault.com/a/689947/186660 by EirikW

Fixes T611.

Test Plan

Type an é in a shell launched in the container.

To launch it, arc shell or docker run --rm -it nasqueron/arcanist bash.

Diff Detail

Repository

rDARC nasqueron/arcanist Docker image

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 229.Dec 1 2015, 08:46

dereckson added a task: T611: nasqueron/arcanist isn't UTF-8 compliant.

dereckson retitled this revision from to Locale set to en_US.UTF-8.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: Sandlayth.

Herald added a project: Docker images. · View Herald TranscriptDec 1 2015, 08:46

Herald added a subscriber: Nasqueron Docker deployment squad. · View Herald Transcript

Another test done: this diff has been created with an image built with this change, the → from the commit were correctly printed and I were able to write an é.

I wonder if that shouldn't go to nasqueron/php-cli.

Sandlayth accepted this revision.Dec 2 2015, 09:24

Sandlayth edited edge metadata.

This revision is now accepted and ready to land.Dec 2 2015, 09:24

Closed by commit rDARC7ee6ff557e49: Locale set to en_US.UTF-8 (authored by dereckson, committed by dereckson). · Explain WhyDec 11 2015, 01:13

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

11 lines

Diff 236

Dockerfile

Loading...