Paths

Table of Contentst

Differential D974

Map shells by OS
ClosedPublic
Actions

Authored by dereckson on Apr 27 2017, 22:23.

Tags

None

Referenced Files

	F3773760: D974.diff
	Sun, Nov 24, 08:23

	Unknown Object (File)
	Tue, Nov 19, 07:46

	Unknown Object (File)
	Mon, Nov 18, 11:47

	Unknown Object (File)
	Mon, Nov 18, 08:36

	Unknown Object (File)
	Sun, Nov 17, 21:09

	Unknown Object (File)
	Sat, Nov 16, 05:18

	Unknown Object (File)
	Sat, Nov 16, 02:42

	Unknown Object (File)
	Fri, Nov 15, 16:22

Subscribers

Details

Reviewers

xcombelle
dereckson

Maniphest Tasks

T1193: Simplify shell config on Eglide

Commits

rOPScbdd94b37c5c: Map shells by OS

Summary

Currently, the users list provide absolute, linux-centric paths
to the shell. Instead, we store only now the shell name, and
provide a map to resolve this shell name by OS.

Signed-off-by: Sébastien Santoro <dereckson@espace-win.org>

Test Plan

Apply roles/shellserver/users state, check no shell change.

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Unit

No Test Coverage

Branch

arcpatch-D974

Build Status

Buildable 1592
Build 1840: arc lint + arc unit

Event Timeline

xcombelle created this revision.Apr 27 2017, 22:23

So next step is to create a map in map.jinja file, with paths for 2 or 3 families, "debian", "freebsd" and perhaps "fedora" so we cover Dwellers too, a CentOS machine, but I'm not sure it's different than Debian.

dereckson commandeered this revision.Sep 16 2017, 09:49

dereckson added a reviewer: xcombelle.

provide a map
use the map in users role

Signed off.

dereckson accepted this revision.Sep 16 2017, 10:10

dereckson edited the test plan for this revision. (Show Details)

dereckson edited the test plan for this revision. (Show Details)

dereckson retitled this revision from adapt shellusers.sls to remove the need of template to Map shells by OS.

dereckson edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Sep 16 2017, 10:11

Closed by commit rOPScbdd94b37c5c: Map shells by OS (authored by xcombelle, committed by dereckson). · Explain WhySep 16 2017, 10:13

This revision was automatically updated to reflect the committed changes.

dereckson added a task: T1193: Simplify shell config on Eglide.Sep 16 2017, 10:17

dereckson mentioned this in T706: Update default shell and user settings on Ysul.Dec 17 2023, 13:13

Revision Contents
Changeset List

Path

Size

13 lines

pillar/

users/

12 lines

roles/

shellserver/

users/

4 lines

Diff 2592

map.jinja

Loading...

pillar/users/shellusers.sls

Loading...

roles/shellserver/users/init.sls

Loading...