Page MenuHomeDevCentral
Differential D1008

Add native label and writing system claims to names
ClosedPublic
Actions

Authored by dereckson on Sep 2 2017, 23:04.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 22:10
Unknown Object (File)
Fri, Dec 20, 22:10
Unknown Object (File)
Fri, Dec 20, 22:10
Unknown Object (File)
Fri, Dec 20, 22:10
Unknown Object (File)
Fri, Dec 20, 22:10
Unknown Object (File)
Fri, Dec 20, 21:42
Unknown Object (File)
Fri, Dec 20, 21:17
Unknown Object (File)
Fri, Dec 13, 02:39
View All Files
Subscribers
None

Details

Reviewers
• Ash-Crow
dereckson
Commits
rDWD720fb6fa4fd2: Add native label and writing system claims to names
Summary

Initially submitted by @Tpt

https://github.com/dereckson/Daeghrefn-Wikidata/pull/3

Test Plan

Tested through three items:

  • Q40195844 (given name, without gender specified)
  • Q40196042 (female given name)
  • Q40196829 (surname, already existing and merged manually afterwards)

Thanks to Yann for the Tushar and Shrestha submissions.

Diff Detail

Repository
rDWD Dæghrefn Wikidata access layer
Lint
Lint Passed
Unit
No Test Coverage
Branch
arcpatch-D1008
Build Status
Buildable 1595
Build 1843: arc lint + arc unit

Event Timeline

dereckson created this revision.Sep 2 2017, 23:04
dereckson updated this revision to Diff 2575.Sep 2 2017, 23:07
dereckson edited edge metadata.

Rebased against master.

Harbormaster completed remote builds in B1581: Diff 2575.Sep 2 2017, 23:07
dereckson updated this revision to Diff 2576.Sep 2 2017, 23:11

Fixed commit selection

Harbormaster completed remote builds in B1582: Diff 2576.Sep 2 2017, 23:11
dereckson edited the summary of this revision. (Show Details)Sep 14 2017, 14:40
dereckson accepted this revision.Sep 18 2017, 10:20

Test items:

This revision is now accepted and ready to land.Sep 18 2017, 10:20
dereckson updated this revision to Diff 2598.Sep 18 2017, 10:25

Describe claims

Harbormaster completed remote builds in B1595: Diff 2598.Sep 18 2017, 10:25
dereckson accepted this revision.Sep 18 2017, 10:33
dereckson retitled this revision from Adds more date to given name and surname items to Add native label and writing system claims to names.
dereckson edited the test plan for this revision. (Show Details)
Closed by commit rDWD720fb6fa4fd2: Add native label and writing system claims to names (authored by Tpt <thomaspt@hotmail.fr>, committed by dereckson). · Explain WhySep 18 2017, 10:38
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
16 lines
16 lines

Diff 2598

View Options

create_given_name

Loading...
View Options

create_surname

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator