Page MenuHomeDevCentral
Differential D1059

Add more packages to map
ClosedPublic
Actions

Authored by dereckson on Oct 15 2017, 22:19.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 26, 05:32
Unknown Object (File)
Fri, Jan 24, 05:38
Unknown Object (File)
Fri, Jan 24, 01:50
Unknown Object (File)
Thu, Jan 23, 14:46
Unknown Object (File)
Wed, Jan 22, 18:30
Unknown Object (File)
Tue, Jan 21, 14:28
Unknown Object (File)
Sun, Jan 19, 23:43
Unknown Object (File)
Sun, Jan 19, 11:12
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rOPS0dcb9e885a82: Add more packages to map
Summary

38b7d85c introduced a jinja map for directories,
2995a8f6 more recently added an entry for packages too.

This change adds more packages to this new entry,
to get rid of some if condition by OS or family.

Test Plan

Ensure the edited states are no-op (see P264).

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
pkg (branched from master)
Build Status
Buildable 1672
Build 1920: arc lint + arc unit

Event Timeline

dereckson created this revision.Oct 15 2017, 22:19
Harbormaster completed remote builds in B1668: Diff 2709.Oct 15 2017, 22:19
dereckson planned changes to this revision.Oct 15 2017, 22:22
dereckson added inline comments.
roles/shellserver/userland-software/base.sls
9

jinja, ""

dereckson updated this revision to Diff 2710.Oct 15 2017, 22:23

Fix import

Harbormaster completed remote builds in B1669: Diff 2710.Oct 15 2017, 22:23
dereckson updated this revision to Diff 2711.Oct 15 2017, 22:28

Fix typo in map.jinja

Harbormaster completed remote builds in B1670: Diff 2711.Oct 15 2017, 22:28
dereckson updated this revision to Diff 2712.Oct 15 2017, 22:31

Import clause is code, not variable

dereckson updated this revision to Diff 2713.Oct 15 2017, 22:32

Removed orphan endif

Harbormaster completed remote builds in B1672: Diff 2713.Oct 15 2017, 22:32
dereckson updated this revision to Diff 2714.Oct 15 2017, 22:34

s/package/packages ; s/aspell/aspell-fr

Harbormaster completed remote builds in B1673: Diff 2714.Oct 15 2017, 22:34
dereckson accepted this revision.Oct 15 2017, 22:36
dereckson edited the test plan for this revision. (Show Details)

P264 salt-state-test-D1059.txt
1Script started on Sun Oct 15 22:28:02 2017
2/opt/nasqueron-operations (pkg) ] salt eglide state.apply roles/core/letsencrypt/software test=True
3eglide:
4----------
5  ID: letsencrypt_software
6 Function: pkg.installed
7  Name: certbot
8  Result: True
9  Comment: Package certbot is already installed
10  Started: 22:28:27.535079
11 Duration: 2995.701 ms
12 Changes: 
13----------
14  ID: /var/letsencrypt-auto
15 Function: file.directory
16  Result: True
17  Comment: The directory /var/letsencrypt-auto is in the correct state
18  Started: 22:28:30.554724
19 Duration: 5.099 ms
20 Changes: 
21----------
22  ID: /etc/letsencrypt/cli.ini
23 Function: file.managed
24  Result: True
25  Comment: The file /etc/letsencrypt/cli.ini is in the correct state
26  Started: 22:28:30.560873
27 Duration: 415.221 ms
28 Changes: 
29
30Summary for eglide
31------------
32Succeeded: 3
33Failed: 0
34------------
35Total states run: 3
36Total run time: 3.416 s
37/opt/nasqueron-operations (pkg) ] salt eglide state.apply roles/core/letsencrypt/software test=True[1@s[1@h[10@ellserver/[1@d[1@a[7@tabase/[1@m[1@y[1@s[1@q[1@l
38eglide:
39----------
40  ID: mysql
41 Function: pkg.installed
42  Result: True
43  Comment: All specified packages are already installed
44  Started: 22:29:50.199322
45 Duration: 2986.005 ms
46 Changes: 
47----------
48  ID: full_text_search_stopwords_file
49 Function: file.managed
50  Name: /opt/stopwords.txt
51  Result: True
52  Comment: The file /opt/stopwords.txt is in the correct state
53  Started: 22:29:53.198950
54 Duration: 156.441 ms
55 Changes: 
56----------
57  ID: mysql_config
58 Function: file.managed
59  Name: /etc/my.cnf
60  Result: True
61  Comment: The file /etc/my.cnf is in the correct state
62  Started: 22:29:53.356419
63 Duration: 44.788 ms
64 Changes: 
65
66Summary for eglide
67------------
68Succeeded: 3
69Failed: 0
70------------
71Total states run: 3
72Total run time: 3.187 s
73…
74/opt/nasqueron-operations (pkg) ] salt eglide state.apply roles/shellserver/userland-software/base test=True
75eglide:
76----------
77  ID: shells
78 Function: pkg.installed
79  Result: True
80  Comment: All specified packages are already installed
81  Started: 22:34:10.049650
82 Duration: 2980.876 ms
83 Changes: 
84----------
85  ID: editors
86 Function: pkg.installed
87  Result: True
88  Comment: All specified packages are already installed
89  Started: 22:34:13.031858
90 Duration: 70.548 ms
91 Changes: 
92----------
93  ID: utilities
94 Function: pkg.installed
95  Result: True
96  Comment: All specified packages are already installed
97  Started: 22:34:13.103461
98 Duration: 71.222 ms
99 Changes: 
100----------
101  ID: dev
102 Function: pkg.installed
103  Result: True
104  Comment: All specified packages are already installed
105  Started: 22:34:13.175708
106 Duration: 72.749 ms
107 Changes: 
108----------
109  ID: dev_popular_libs
110 Function: pkg.installed
111  Result: True
112  Comment: All specified packages are already installed
113  Started: 22:34:13.249541
114 Duration: 68.081 ms
115 Changes: 
116----------
117  ID: languages_removed
118 Function: pkg.removed
119  Result: True
120  Comment: All specified packages are already absent
121  Started: 22:34:13.318658
122 Duration: 131.844 ms
123 Changes: 
124----------
125  ID: languages
126 Function: pkg.installed
127  Result: True
128  Comment: All specified packages are already installed
129  Started: 22:34:13.451609
130 Duration: 69.819 ms
131 Changes: 
132----------
133  ID: languages_libs
134 Function: pkg.installed
135  Result: True
136  Comment: All specified packages are already installed
137  Started: 22:34:13.522532
138 Duration: 68.151 ms
139 Changes: 
140----------
141  ID: spelling
142 Function: pkg.installed
143  Result: True
144  Comment: All specified packages are already installed
145  Started: 22:34:13.591779
146 Duration: 68.849 ms
147 Changes: 
148
149Summary for eglide
150------------
151Succeeded: 9
152Failed: 0
153------------
154Total states run: 9
155Total run time: 3.602 s
156/opt/nasqueron-operations (pkg) ] ^Dexit
157
158Script done on Sun Oct 15 22:34:33 2017

This revision is now accepted and ready to land.Oct 15 2017, 22:36
Closed by commit rOPS0dcb9e885a82: Add more packages to map (authored by dereckson). · Explain WhyOct 15 2017, 22:37
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
28 lines
roles/
core/
letsencrypt/
9 lines
shellserver/
database/
8 lines
userland-software/
30 lines

Diff 2713

View Options

map.jinja

Loading...
View Options

roles/core/letsencrypt/software.sls

Loading...
View Options

roles/shellserver/database/mysql.sls

Loading...
View Options

roles/shellserver/userland-software/base.sls

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator