Improve PhabricatorAPI::getFirstResult()
ClosedPublic
Actions

Authored by dereckson on Dec 25 2015, 20:21.

Details

Reviewers

dereckson

Commits

Unknown Object (Diffusion Commit)
rNOTIF6ebadee4752e: Improve PhabricatorAPI::getFirstResult()

Summary

Handle replies with a data property.

Test Plan

Check the result of this method for the replies returned
by the different API methods used in PhabricatorStory
to get the projects.

Diff Detail

Repository

rNOTIF Notifications center

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

getProjects

Build Status

Buildable 149
Build 149: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 291.Dec 25 2015, 20:21

dereckson retitled this revision from to Improve PhabricatorAPI::getFirstResult().

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson planned changes to this revision.Dec 25 2015, 20:22

dereckson added inline comments.

app/Phabricator/PhabricatorAPI.php
127	'data'

Quote issue.

dereckson accepted this revision.Dec 25 2015, 20:23

dereckson edited edge metadata.

This revision is now accepted and ready to land.Dec 25 2015, 20:23

Closed by commit rNOTIF6ebadee4752e: Improve PhabricatorAPI::getFirstResult() (authored by dereckson, committed by dereckson). · Explain WhyDec 25 2015, 20:23

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Phabricator/

PhabricatorAPI.php

4 lines

Diff 292

View Options

app/Phabricator/PhabricatorAPI.php

Improve PhabricatorAPI::getFirstResult()ClosedPublicActions