Differential D1230

Make the FANTOIR code more pythonic
ClosedPublic
Actions

Authored by xcombelle on Nov 17 2017, 15:01.

Details

Reviewers

dereckson

Commits

rOPS383baa5be2cf: Make the FANTOIR code more pythonic
rOPS22090aeb3a7e: Make the FANTOIR code more pythonic

Summary

Scripts with functions should allow to be included in other source files.

Apply more pythonic style. Ask forgiveness not permission.

Test Plan

Check if the behavior is unchanged.

./extract_streets.py FANTOIR1017 before.txt

git pull

./extract_streets.py FANTOIR1017 after.txt

diff before.txt after.txt

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

xcombelle created this revision.Nov 17 2017, 15:01

dereckson accepted this revision.Nov 17 2017, 19:15

This revision is now accepted and ready to land.Nov 17 2017, 19:15

dereckson retitled this revision from make the FANTOIR code more pythonic to Make the FANTOIR code more pythonic.Nov 17 2017, 19:24

dereckson edited the test plan for this revision. (Show Details)

PEP-8 style

Harbormaster completed remote builds in B1954: Diff 3162.Nov 17 2017, 19:30

$ arc patch D1230
$ autopep8 ./roles/viperserv/fantoir/files/extract_streets.py > e
$ mv e ./roles/viperserv/fantoir/files/extract_streets.py
$ flake8 ./roles/viperserv/fantoir/files/extract_streets.py
./roles/viperserv/fantoir/files/extract_streets.py:17:37: F841 local variable 'output' is assigned to but never used                                           
./roles/viperserv/fantoir/files/extract_streets.py:17:80: E501 line too long (80 > 79 characters)                                                              
./roles/viperserv/fantoir/files/extract_streets.py:23:21: F821 undefined name 'fd'                                                                             
./roles/viperserv/fantoir/files/extract_streets.py:31:80: E501 line too long (83 > 79 characters)