By nature, cmd.run is an imperative order more than a descriptive one.
This change ensures:
- file.managed is used to set file modes/ownership
- the descriptive creates is used instead of unless: test -f ...
Fixes T1349.
Details
Details
- Reviewers
dereckson - Maniphest Tasks
- T1349: Use file.managed instead of cmd.run chown/chmod for odderon_fix_permissions_and_ownership
- Commits
- rOPS69b7ff3224a4: Improve cmd.run usage
$ salt eglide state.apply roles/shellserver/odderon/config […] Comment: File /opt/odderon/var/darkbot/userlist.db exists with proper permissions. No changes made. […] $ salt eglide state.apply roles/webserver-core/letsencrypt/certificates test=True […] Comment: /etc/letsencrypt/live/www.eglide.org/fullchain.pem exists […]
Diff Detail
Diff Detail
- Repository
- rOPS Nasqueron Operations
- Lint
Lint Passed - Unit
No Test Coverage - Branch
- clean-cmd-run (branched from master)
- Build Status
Buildable 2142 Build 2390: arc lint + arc unit