Page MenuHomeDevCentral

Improve cmd.run usage
ClosedPublic

Authored by dereckson on Feb 28 2018, 15:20.
Tags
None
Referenced Files
F3715941: D1359.id3477.diff
Tue, Nov 5, 11:30
F3715822: D1359.diff
Tue, Nov 5, 09:33
Unknown Object (File)
Sat, Oct 26, 04:50
Unknown Object (File)
Wed, Oct 16, 11:13
Unknown Object (File)
Tue, Oct 15, 04:57
Unknown Object (File)
Sat, Oct 12, 09:05
Unknown Object (File)
Sat, Oct 12, 09:04
Unknown Object (File)
Wed, Oct 9, 08:54
Subscribers
None

Details

Summary

By nature, cmd.run is an imperative order more than a descriptive one.

This change ensures:

  • file.managed is used to set file modes/ownership
  • the descriptive creates is used instead of unless: test -f ...

Fixes T1349.

Test Plan
$ salt eglide state.apply roles/shellserver/odderon/config
[…]
Comment: File /opt/odderon/var/darkbot/userlist.db exists with proper permissions. No changes made.
[…]
$ salt eglide state.apply roles/webserver-core/letsencrypt/certificates test=True
[…]
Comment: /etc/letsencrypt/live/www.eglide.org/fullchain.pem exists
[…]

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Feb 28 2018, 15:21
This revision was automatically updated to reflect the committed changes.