Page MenuHomeDevCentral
Differential D1423

Rename node.list to node.get_list
ClosedPublic
Actions

Authored by dereckson on Mar 15 2018, 20:58.
Tags
None
Referenced Files
F11666463: D1423.diff
Sun, Sep 7, 23:16
Unknown Object (File)
Fri, Sep 5, 07:35
Unknown Object (File)
Fri, Sep 5, 05:03
Unknown Object (File)
Fri, Sep 5, 02:06
Unknown Object (File)
Thu, Sep 4, 21:18
Unknown Object (File)
Wed, Sep 3, 19:24
Unknown Object (File)
Tue, Sep 2, 01:45
Unknown Object (File)
Mon, Aug 25, 10:06
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rOPSc74a7b83998d: Rename node.list to node.get_list
Summary

list() is the constructor for the Python list

Test Plan

salt * node.get_list roles

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
list-or-list
Build Status
Buildable 2232
Build 2480: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 15 2018, 20:58
dereckson created this revision.
Harbormaster completed remote builds in B2231: Diff 3629.Mar 15 2018, 20:58
dereckson updated this revision to Diff 3630.Mar 15 2018, 21:01

Rename in states

Harbormaster completed remote builds in B2232: Diff 3630.Mar 15 2018, 21:01
dereckson accepted this revision.Mar 15 2018, 21:02
This revision is now accepted and ready to land.Mar 15 2018, 21:02
Closed by commit rOPSc74a7b83998d: Rename node.list to node.get_list (authored by dereckson). · Explain WhyMar 15 2018, 21:02
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
_modules/
6 lines
roles/
core/
network/
2 lines
salt/
2 lines

Diff 3630

View Options

_modules/node.py

Loading...
View Options

roles/core/network/init.sls

Loading...
View Options

roles/core/salt/init.sls

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator