Differential D1434

Correctly expand shell arguments
ClosedPublic
Actions

Authored by dereckson on Mar 16 2018, 03:15.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 18, 18:24

	Unknown Object (File)
	Wed, Dec 18, 18:24

	Unknown Object (File)
	Wed, Dec 18, 18:03

	Unknown Object (File)
	Wed, Dec 18, 18:03

	Unknown Object (File)
	Tue, Dec 17, 04:51

	Unknown Object (File)
	Tue, Dec 17, 01:39

	Unknown Object (File)
	Tue, Dec 17, 01:39

	Unknown Object (File)
	Tue, Dec 17, 01:39

Subscribers

None

Details

Reviewers

Commits

rOPSbf659c5728cb: Correctly expand shell arguments

Summary

$* → "$@"

Reference: https://github.com/koalaman/shellcheck/wiki/SC2048

Test Plan

Tested on Equatower

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Severity	Location	Code	Message
Advice	roles/phabricator/arcanist/files/arc.sh:67	SC2086	SHELLCHECK
Advice	roles/phabricator/arcanist/files/arc.sh:67	SC2086	SHELLCHECK
Advice	roles/phabricator/arcanist/files/arc.sh:69	SC2086	SHELLCHECK
Advice	roles/phabricator/arcanist/files/arc.sh:69	SC2086	SHELLCHECK

Unit

No Test Coverage

Branch

star-returns (branched from master)

Build Status

Buildable 2253
Build 2501: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 16 2018, 03:15

dereckson created this revision.

Harbormaster completed remote builds in B2252: Diff 3662.Mar 16 2018, 03:15

arc too

Harbormaster completed remote builds in B2253: Diff 3663.Mar 16 2018, 03:16

Advices are for other arguments (yes this script should be checked)

This revision is now accepted and ready to land.Mar 16 2018, 03:18

Closed by commit rOPSbf659c5728cb: Correctly expand shell arguments (authored by dereckson). · Explain WhyMar 16 2018, 03:19

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

roles/

paas-docker/

wrappers/

files/

2 lines

phabricator/

arcanist/

files/

4 lines

Diff 3663

roles/paas-docker/wrappers/files/certbot.sh

Loading...

roles/phabricator/arcanist/files/arc.sh

Loading...