Correctly expand shell arguments
ClosedPublic
Actions

Authored by dereckson on Mar 16 2018, 03:15.

Tags

None

Referenced Files

	F3920594: D1434.id3663.diff
	Fri, Dec 20, 16:36

	F3920583: D1434.id3664.diff
	Fri, Dec 20, 16:32

	F3920562: D1434.id3662.diff
	Fri, Dec 20, 16:26

	F3919303: D1434.diff
	Fri, Dec 20, 10:27

	Unknown Object (File)
	Wed, Dec 18, 18:24

	Unknown Object (File)
	Wed, Dec 18, 18:24

	Unknown Object (File)
	Wed, Dec 18, 18:03

	Unknown Object (File)
	Wed, Dec 18, 18:03

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rOPSbf659c5728cb: Correctly expand shell arguments

Summary

$* → "$@"

Reference: https://github.com/koalaman/shellcheck/wiki/SC2048

Test Plan

Tested on Equatower

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Mar 16 2018, 03:15

dereckson created this revision.

Harbormaster completed remote builds in B2252: Diff 3662.Mar 16 2018, 03:15

arc too

Harbormaster completed remote builds in B2253: Diff 3663.Mar 16 2018, 03:16

Advices are for other arguments (yes this script should be checked)

This revision is now accepted and ready to land.Mar 16 2018, 03:18

Closed by commit rOPSbf659c5728cb: Correctly expand shell arguments (authored by dereckson). · Explain WhyMar 16 2018, 03:19

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

roles/

paas-docker/

wrappers/

files/

certbot.sh

2 lines

phabricator/

arcanist/

files/

arc.sh

4 lines

Diff 3664

View Options

roles/paas-docker/wrappers/files/certbot.sh