Check shell command receives enough arguments
ClosedPublic
Actions

Authored by dereckson on Mar 25 2018, 14:03.

Details

Reviewers

dereckson

Commits

rOPS45443dd1a569: Check shell command receives enough arguments

Summary

shell allows handlers with an arbitray number of required arguments.

This change handles the case where such an argument is missing.

Test Plan

~/.shell.yml

handlers:
  tools:
    server: "dev.tools.wmflabs.org"
    command: ['become', '{{%s}}']
    interactive: True

$ shell tools
shell: Required argument is missing.
$ shell tools translate
tools.translate@tools-bastion-02:~$

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Unit

No Test Coverage

Branch

feature/shell (branched from master)

Build Status

Buildable 2354
Build 2602: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 25 2018, 14:03

dereckson created this revision.

Harbormaster completed remote builds in B2354: Diff 3826.Mar 25 2018, 14:03

dereckson accepted this revision.Mar 25 2018, 14:04

This revision is now accepted and ready to land.Mar 25 2018, 14:04

Closed by commit rOPS45443dd1a569: Check shell command receives enough arguments (authored by dereckson). · Explain WhyMar 25 2018, 14:05

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

roles/

devserver/

userland-software/

files/

shell.py

3 lines

Diff 3826

View Options

roles/devserver/userland-software/files/shell.py

Check shell command receives enough argumentsClosedPublicActions