Page MenuHomeDevCentral

Services
ClosedPublic

Authored by dereckson on Jan 2 2016, 23:43.
Tags
None
Referenced Files
F3752653: D160.id384.diff
Sun, Nov 17, 20:30
F3752626: D160.id385.diff
Sun, Nov 17, 20:24
F3752336: D160.diff
Sun, Nov 17, 18:26
Unknown Object (File)
Wed, Nov 13, 01:22
Unknown Object (File)
Tue, Nov 12, 20:58
Unknown Object (File)
Mon, Nov 11, 06:06
Unknown Object (File)
Fri, Nov 8, 12:46
Unknown Object (File)
Thu, Nov 7, 16:59
Subscribers
None

Details

Reviewers
dereckson
Commits
Unknown Object (Diffusion Commit)
rNOTIF2be5bb93d3bf: Services
Summary

Several classes implemented some methods to query credentials.json file.

We create a Services class to move and generalize these methods into.

Test Plan

Same as D157

  • php artisan phabricator:projectsmap
  • Test a GitHub payload request
  • Test a Phabricator payload request

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson retitled this revision from to Services.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson added inline comments.
app/Http/Controllers/Gate/GateController.php
84

extraneous space

dereckson edited edge metadata.

Removed extraneous space

dereckson edited edge metadata.
dereckson marked an inline comment as done.
This revision is now accepted and ready to land.Jan 2 2016, 23:46
This revision was automatically updated to reflect the committed changes.