Paths

Table of Contentst

Avoid both assignment and comparison in same time
ClosedPublic
Actions

Authored by dereckson on Mar 29 2018, 21:34.

Tags

None

Referenced Files

	F14680684: D1538.id.diff
	Sun, Nov 30, 00:16

	Unknown Object (File)
	Wed, Nov 12, 08:16

	Unknown Object (File)
	Wed, Nov 12, 05:42

	Unknown Object (File)
	Wed, Nov 12, 04:24

	Unknown Object (File)
	Wed, Nov 12, 01:30

	Unknown Object (File)
	Tue, Nov 11, 22:48

	Unknown Object (File)
	Tue, Nov 11, 19:47

	Unknown Object (File)
	Mon, Nov 10, 16:11

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rNOTIF0575d2497ed6: Avoid both assignment and comparison in same time

Test Plan

phpcs with Generic.CodeAnalysis.AssignmentInCondition rule

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Test Failures

Branch

no-assignment-within-condition

Build Status

Buildable 2412
Build 2660: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	Unknown Unit Message ("")

Event Timeline

dereckson requested review of this revision.Mar 29 2018, 21:34

dereckson created this revision.

Harbormaster failed remote builds in B2412: Diff 3924!Mar 29 2018, 21:34

Not so no op

Rebase

Harbormaster completed remote builds in B2414: Diff 3927.Mar 29 2018, 21:55

dereckson accepted this revision.Mar 29 2018, 21:55

This revision is now accepted and ready to land.Mar 29 2018, 21:55

Closed by commit rNOTIF0575d2497ed6: Avoid both assignment and comparison in same time (authored by dereckson). · Explain WhyMar 29 2018, 21:56

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Analyzers/

GitHub/

Events/

RepositoryEvent.php

3 lines

Diff 3924

View Options

app/Analyzers/GitHub/Events/RepositoryEvent.php

Avoid both assignment and comparison in same timeClosedPublicActions