Paths

Table of Contentst

Avoid both assignment and comparison in same time
ClosedPublic
Actions

Authored by dereckson on Mar 29 2018, 21:34.

Tags

None

Referenced Files

	F3749906: D1538.id3927.diff
	Sat, Nov 16, 18:57

	F3749887: D1538.id3928.diff
	Sat, Nov 16, 18:50

	F3749610: D1538.diff
	Sat, Nov 16, 16:31

	F3747525: D1538.id3928.diff
	Sat, Nov 16, 02:36

	F3747524: D1538.id3927.diff
	Sat, Nov 16, 02:36

	F3747523: D1538.id3924.diff
	Sat, Nov 16, 02:36

	Unknown Object (File)
	Wed, Nov 13, 09:04

	Unknown Object (File)
	Thu, Oct 31, 22:54

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rNOTIF0575d2497ed6: Avoid both assignment and comparison in same time

Test Plan

phpcs with Generic.CodeAnalysis.AssignmentInCondition rule

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Mar 29 2018, 21:34

dereckson created this revision.

Harbormaster failed remote builds in B2412: Diff 3924!Mar 29 2018, 21:34

Not so no op

Rebase

Harbormaster completed remote builds in B2414: Diff 3927.Mar 29 2018, 21:55

dereckson accepted this revision.Mar 29 2018, 21:55

This revision is now accepted and ready to land.Mar 29 2018, 21:55

Closed by commit rNOTIF0575d2497ed6: Avoid both assignment and comparison in same time (authored by dereckson). · Explain WhyMar 29 2018, 21:56

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Analyzers/

GitHub/

Events/

RepositoryEvent.php

3 lines

Diff 3928

View Options

app/Analyzers/GitHub/Events/RepositoryEvent.php

Avoid both assignment and comparison in same timeClosedPublicActions