Test and fix PhabricatorStory::mapPhabricatorFeedKey
ClosedPublic
Actions

Authored by dereckson on Mar 29 2018, 23:33.

Tags

None

Referenced Files

	F3749626: D1542.id3934.diff
	Sat, Nov 16, 16:37

	F3749624: D1542.id3938.diff
	Sat, Nov 16, 16:35

	F3749615: D1542.id3933.diff
	Sat, Nov 16, 16:33

	F3749587: D1542.id3937.diff
	Sat, Nov 16, 16:24

	F3749307: D1542.diff
	Sat, Nov 16, 14:27

	F3747517: D1542.id3938.diff
	Sat, Nov 16, 02:36

	F3747516: D1542.id3937.diff
	Sat, Nov 16, 02:36

	Unknown Object (File)
	Tue, Nov 12, 16:43

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rNOTIF09004d0d899c: Test and fix PhabricatorStory::mapPhabricatorFeedKey

Test Plan

New unit test, and a fix for the "story" $key

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Tests Passed

Branch

test/mapPhabricatorFeedKey (branched from master)

Build Status

Buildable 2417
Build 2665: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 29 2018, 23:33

dereckson created this revision.

Harbormaster completed remote builds in B2417: Diff 3933.Mar 29 2018, 23:33

Let story stay story, the goal is to rename storyFoo to foo.

Harbormaster completed remote builds in B2418: Diff 3934.Mar 29 2018, 23:36

rebase

Harbormaster completed remote builds in B2420: Diff 3937.Mar 29 2018, 23:40

dereckson accepted this revision.Mar 29 2018, 23:40

This revision is now accepted and ready to land.Mar 29 2018, 23:40

Closed by commit rNOTIF09004d0d899c: Test and fix PhabricatorStory::mapPhabricatorFeedKey (authored by dereckson). · Explain WhyMar 29 2018, 23:40

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Phabricator/

PhabricatorStory.php

5 lines

tests/

Phabricator/

PhabricatorStoryTest.php

18 lines

Diff 3933

View Options

app/Phabricator/PhabricatorStory.php