Extract complex condition in its own method
ClosedPublic
Actions

Authored by dereckson on Mar 29 2018, 23:47.

Tags

None

Referenced Files

	F20258539: D1544.id.diff
	Wed, Jan 7, 04:20

	F20240055: D1544.diff
	Tue, Jan 6, 21:55

	F20209158: D1544.diff
	Tue, Jan 6, 12:10

	Unknown Object (File)
	Fri, Jan 2, 15:15

	Unknown Object (File)
	Thu, Jan 1, 23:37

	Unknown Object (File)
	Thu, Jan 1, 23:36

	Unknown Object (File)
	Thu, Jan 1, 23:33

	Unknown Object (File)
	Thu, Jan 1, 23:33

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rNOTIFbe3382f3ca03: Extract complex condition in its own method

Test Plan

Unit test introduced in f19194a38dab.

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Tests Passed

Branch

isVoidObjectType

Build Status

Buildable 2422
Build 2670: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 29 2018, 23:47

dereckson created this revision.

Harbormaster completed remote builds in B2421: Diff 3939.Mar 29 2018, 23:47

dereckson planned changes to this revision.Mar 29 2018, 23:48

dereckson added inline comments.

app/Phabricator/PhabricatorStory.php
126	has

s/is/has

Harbormaster completed remote builds in B2422: Diff 3940.Mar 29 2018, 23:48

dereckson accepted this revision.Mar 29 2018, 23:49

This revision is now accepted and ready to land.Mar 29 2018, 23:49

Closed by commit rNOTIFbe3382f3ca03: Extract complex condition in its own method (authored by dereckson). · Explain WhyMar 29 2018, 23:49

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Phabricator/

PhabricatorStory.php

6 lines

Diff 3940

View Options

app/Phabricator/PhabricatorStory.php

Extract complex condition in its own methodClosedPublicActions