Page MenuHomeDevCentral

Extract complex condition in its own method
ClosedPublic

Authored by dereckson on Mar 29 2018, 23:47.
Tags
None
Referenced Files
F7591577: D1544.id3941.diff
Tue, Apr 29, 08:17
Unknown Object (File)
Sun, Apr 27, 16:23
Unknown Object (File)
Sun, Apr 27, 11:26
Unknown Object (File)
Sat, Apr 26, 12:27
Unknown Object (File)
Mon, Apr 21, 04:56
Unknown Object (File)
Thu, Apr 17, 10:40
Unknown Object (File)
Thu, Apr 17, 00:53
Unknown Object (File)
Thu, Apr 17, 00:49
Subscribers
None

Details

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
isVoidObjectType
Build Status
Buildable 2422
Build 2670: arc lint + arc unit

Event Timeline

dereckson created this revision.
dereckson added inline comments.
app/Phabricator/PhabricatorStory.php
126

has

dereckson marked an inline comment as done.

s/is/has

This revision is now accepted and ready to land.Mar 29 2018, 23:49
This revision was automatically updated to reflect the committed changes.