Paths

Table of Contentst

Differential D1546

Implement assertions specific to command display
ClosedPublic
Actions

Authored by dereckson on Mar 30 2018, 00:28.

Tags

None

Referenced Files

	F6959001: D1546.id3944.diff
	Fri, Apr 18, 04:11

	F6958951: D1546.id3945.diff
	Fri, Apr 18, 04:10

	Unknown Object (File)
	Wed, Apr 16, 12:51

	Unknown Object (File)
	Tue, Apr 8, 10:34

	Unknown Object (File)
	Mon, Apr 7, 20:28

	Unknown Object (File)
	Mon, Apr 7, 15:31

	Unknown Object (File)
	Mon, Apr 7, 11:13

	Unknown Object (File)
	Sun, Apr 6, 06:17

Subscribers

None

Details

Reviewers

Commits

rNOTIF74227dcbd4de: Implement assertions specific to command display

Summary

This avoids to repeat $this->tester->getDisplay() everywhere.

Test Plan

Tests passes.

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Test Failures

Branch

tests-assert-display

Build Status

Buildable 2425
Build 2673: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	0 ms	Unknown Unit Message ("") No tests found in class "Nasqueron\Notifications\Tests\TestCase".
	238 ms	Unknown Unit Message ("")
	680 ms	Unknown Unit Message ("")
	66 ms	Unknown Unit Message ("")
	59 ms	Unknown Unit Message ("")
		View Full Test Results (1 Failed · 15 Passed)

Event Timeline

dereckson requested review of this revision.Mar 30 2018, 00:28

dereckson created this revision.

Harbormaster failed remote builds in B2425: Diff 3944!Mar 30 2018, 00:28

dereckson accepted this revision.Mar 30 2018, 00:29

This revision is now accepted and ready to land.Mar 30 2018, 00:29

Closed by commit rNOTIF74227dcbd4de: Implement assertions specific to command display (authored by dereckson). · Explain WhyMar 30 2018, 00:30

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

tests/

Console/

Commands/

ConfigShowTest.php

22 lines

ConfigValidateTest.php

2 lines

InspireTest.php

2 lines

NotificationsPayloadTest.php

23 lines

PhabricatorProjectsMapTest.php

6 lines

15 lines

Diff 3944

tests/Console/Commands/ConfigShowTest.php

Loading...

tests/Console/Commands/ConfigValidateTest.php

Loading...

tests/Console/Commands/InspireTest.php

Loading...

tests/Console/Commands/NotificationsPayloadTest.php

Loading...

tests/Console/Commands/PhabricatorProjectsMapTest.php

Loading...

tests/Console/Commands/TestCase.php

Loading...