Page MenuHomeDevCentral
Differential D1554

Don't disable SC2046 shellcheck for docker run command
ClosedPublic
Actions

Authored by dereckson on Mar 30 2018, 22:50.
Tags
None
Referenced Files
F24635548: D1554.id3971.diff
Mon, Mar 2, 18:47
F24631718: D1554.id3971.diff
Mon, Mar 2, 14:56
F24631708: D1554.id3970.diff
Mon, Mar 2, 14:55
F24629915: D1554.id3971.diff
Mon, Mar 2, 12:54
F24629890: D1554.id3970.diff
Mon, Mar 2, 12:53
F24625434: D1554.id3971.diff
Mon, Mar 2, 07:32
F24622658: D1554.id3970.diff
Mon, Mar 2, 04:10
F24619652: D1554.id3970.diff
Mon, Mar 2, 00:41
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rOPS7cef420d6afb: Don't disable SC2046 shellcheck for docker run command
Summary

Reported upstream at https://github.com/koalaman/shellcheck/issues/1161

Fixed at https://github.com/koalaman/shellcheck/commit/08d2eef4111afde4

Test Plan

shellcheck roles/paas-docker/wrappers/files/phpbb.sh

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
docker-shellcheck-fix (branched from master)
Build Status
Buildable 2441
Build 2689: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 30 2018, 22:50
dereckson created this revision.
Harbormaster completed remote builds in B2441: Diff 3970.Mar 30 2018, 22:50
dereckson accepted this revision.Mar 30 2018, 22:50
This revision is now accepted and ready to land.Mar 30 2018, 22:50
Closed by commit rOPS7cef420d6afb: Don't disable SC2046 shellcheck for docker run command (authored by dereckson). · Explain WhyMar 30 2018, 22:50
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
roles/
paas-docker/
wrappers/
files/
1 line

Diff 3970

View Options

roles/paas-docker/wrappers/files/phpbb.sh

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator