Page MenuHomeDevCentral
Differential D1555

Use Keruald\Commands package to provide Command class
ClosedPublic
Actions

Authored by dereckson on Mar 30 2018, 23:08.
Tags
None
Referenced Files
F3752094: D1555.id3974.diff
Sun, Nov 17, 15:47
F3752083: D1555.id3973.diff
Sun, Nov 17, 15:33
Unknown Object (File)
Wed, Nov 13, 07:29
Unknown Object (File)
Sun, Nov 10, 08:28
Unknown Object (File)
Sun, Nov 10, 03:08
Unknown Object (File)
Sat, Nov 9, 04:23
Unknown Object (File)
Sat, Nov 9, 03:30
Unknown Object (File)
Thu, Nov 7, 06:20
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T1386: Publish a Keruald library to help testable CLI PHP applications
Commits
rSAASMWd7218170cc2d: Use Keruald\Commands package to provide Command class
Summary

The Command, Display and OutputDisplay class have been extracted
to the Keruald/Commands library in rKCMD21b2d7f16ee9.

This change removes the extracted files and declare the library
as a dependency.

Ref T1386.

Test Plan
  • bin/saas-mediawiki-get-host.php
  • bin/saas-mediawiki-get-host.php nonexisting
  • bin/saas-mediawiki-get-host.php utopia

Diff Detail

Repository
rSAASMW SaaS MediaWiki
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
switch-keruald-commands (branched from master)
Build Status
Buildable 2442
Build 2690: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 30 2018, 23:08
dereckson created this revision.
Harbormaster completed remote builds in B2442: Diff 3973.Mar 30 2018, 23:08
dereckson accepted this revision.Mar 30 2018, 23:09
dereckson retitled this revision from The Command, Display and OutputDisplay class have been extracted to the Keruald/Commands library in rKCMD21b2d7f16ee9. to Use Keruald\Commands package to provide Command class.
dereckson edited the summary of this revision. (Show Details)
dereckson edited the summary of this revision. (Show Details)
dereckson added a task: T1386: Publish a Keruald library to help testable CLI PHP applications.
This revision is now accepted and ready to land.Mar 30 2018, 23:09
Closed by commit rSAASMWd7218170cc2d: Use Keruald\Commands package to provide Command class (authored by dereckson). · Explain WhyMar 30 2018, 23:10
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 3973

View Options

composer.json

Loading...
View Options

src/Utilities/Command.php

Loading...
View Options

src/Utilities/Display.php

Loading...
View Options

src/Utilities/GetHost.php

Loading...
View Options

src/Utilities/OutputDisplay.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator