Ignore false positives log requests
ClosedPublic
Actions

Authored by dereckson on Apr 15 2018, 23:22.

Details

Reviewers

dereckson

Commits

rVIPER30df56d438a5: Ignore false positives log requests

Summary

The [component] message log format triggers some false positive:

for mailing list subjects
for date or time logs

Two strategies are used to avoid them:

a blacklist for ML subjects
a pattern detection to ignore components starting by spaces or digits

Test Plan

Tests are provided for encountered cases.

Diff Detail

Repository

rVIPER ViperServ scripts

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

ignore-date-logs

Build Status

Buildable 2498
Build 2746: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Apr 15 2018, 23:22

dereckson created this revision.

Harbormaster completed remote builds in B2498: Diff 4064.Apr 15 2018, 23:22

This change allows to avoid that too:

04:56:40 < Fauve> https://www.youtube.com/watch?v=1bT77XP52uw Toi Jayce conquérent de la lumière tu dois… conquérir ! :)
04:56:50 < Daeghrefn> [Vid] Jayce et les Conquérants de la Lumière - Générique
04:56:50 < Wearg> Daeghrefn, if you wish to log that, confirm with .+log [Vid] Jayce et les Conquérants de la Lumière - Générique

dereckson accepted this revision.Jun 18 2018, 20:21

This revision is now accepted and ready to land.Jun 18 2018, 20:21

Closed by commit rVIPER30df56d438a5: Ignore false positives log requests (authored by dereckson). · Explain WhyJun 18 2018, 20:26

This revision was automatically updated to reflect the committed changes.