Differential D1654

Deploy for dereckson a playlist generator script on devserver
ClosedPublic
Actions

Authored by dereckson on Jul 21 2018, 15:21.

Tags

None

Referenced Files

	F8420506: D1654.id.diff
	Tue, May 13, 12:35

	Unknown Object (File)
	Fri, May 9, 18:51

	Unknown Object (File)
	Thu, May 8, 18:21

	Unknown Object (File)
	Thu, May 8, 14:30

	Unknown Object (File)
	Thu, May 8, 14:24

	Unknown Object (File)
	Thu, May 8, 12:48

	Unknown Object (File)
	Thu, May 8, 05:36

	Unknown Object (File)
	Thu, May 8, 03:45

Subscribers

None

Details

Reviewers

Commits

rOPS1efecd488fcb: Deploy for dereckson a playlist generator script on devserver

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Unit

No Test Coverage

Branch

http2pls

Build Status

Buildable 2597
Build 2845: arc lint + arc unit

Event Timeline

dereckson created this revision.Jul 21 2018, 15:21

Harbormaster completed remote builds in B2597: Diff 4224.Jul 21 2018, 15:27

dereckson requested review of this revision.Jul 21 2018, 15:27

dereckson planned changes to this revision.Jul 21 2018, 15:50

dereckson added inline comments.

roles/devserver/userland-home/files/dereckson/bin/http2pls
44	If the URL isn't valid, the urlopen function will raise the following exception: ValueError: unknown url type: 'fdfdf' File "/usr/local/lib/python3.6/urllib/request.py", line 384, in _parse raise ValueError("unknown url type: %r" % self.full_url) So a try block could handle URL errors here.
49	two \n

PEP-8 compliant

Harbormaster completed remote builds in B2598: Diff 4225.Jul 22 2018, 12:47

Handle URL errors

Harbormaster completed remote builds in B2599: Diff 4226.Jul 22 2018, 12:58

dereckson accepted this revision.Jul 22 2018, 13:03

dereckson marked an inline comment as done.

This revision is now accepted and ready to land.Jul 22 2018, 13:03

Closed by commit rOPS1efecd488fcb: Deploy for dereckson a playlist generator script on devserver (authored by dereckson). · Explain WhyJul 22 2018, 13:06

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

roles/

devserver/

userland-home/

files/

dereckson/

bin/

57 lines

userland-software/

4 lines

Diff 4224

roles/devserver/userland-home/files/dereckson/bin/http2pls

Loading...

roles/devserver/userland-software/dev.sls

Loading...