Use PHP 7.3 is_countable function when present
ClosedPublic
Actions

Authored by dereckson on Aug 31 2018, 11:58.

Tags

None

Referenced Files

	F10940466: D1655.id4229.diff
	Wed, Aug 6, 16:03

	F10934065: D1655.id4229.diff
	Tue, Aug 5, 21:07

	F10934051: D1655.id4228.diff
	Tue, Aug 5, 21:06

	F10933494: D1655.id4228.diff
	Tue, Aug 5, 19:25

	F10932857: D1655.id.diff
	Tue, Aug 5, 17:26

	Unknown Object (File)
	Tue, Aug 5, 17:00

	Unknown Object (File)
	Mon, Aug 4, 22:54

	Unknown Object (File)
	Mon, Aug 4, 14:27

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rKOT77ed9ddc5399: Use PHP 7.3 is_countable function when present

Summary

The code still keeps a custom implementation to maintain PHP 7.2 compatibility.

Reference: https://wiki.php.net/rfc/is-countable

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Passed

Unit

Tests Passed

Branch

php73

Build Status

Buildable 2600
Build 2848: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Aug 31 2018, 11:58

dereckson created this revision.

Harbormaster completed remote builds in B2600: Diff 4228.Aug 31 2018, 11:58

dereckson accepted this revision.Aug 31 2018, 12:02

This revision is now accepted and ready to land.Aug 31 2018, 12:02

Closed by commit rKOT77ed9ddc5399: Use PHP 7.3 is_countable function when present (authored by dereckson). · Explain WhyAug 31 2018, 12:02

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

Collections/

TraversableUtilities.php

5 lines

Diff 4228

View Options

src/Collections/TraversableUtilities.php

Use PHP 7.3 is_countable function when presentClosedPublicActions