Page MenuHomeDevCentral

Don't check database or provision settings at container startup
ClosedPublic

Authored by dereckson on Sep 18 2018, 22:34.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 10:01
Unknown Object (File)
Mon, Dec 2, 11:44
Unknown Object (File)
Fri, Nov 29, 11:13
Unknown Object (File)
Nov 21 2024, 18:29
Unknown Object (File)
Nov 21 2024, 18:29
Unknown Object (File)
Nov 21 2024, 18:29
Unknown Object (File)
Nov 21 2024, 18:29
Unknown Object (File)
Nov 21 2024, 18:27
Subscribers
None

Details

Summary

Application configuration can be provisioned:

  • through environment
  • through a configuration file

The current image uses environment, which is good, but actually use it
to create a configuration file (which is rather bad, as it's not comprehensive).

Ideally, we should strive to allow Etherpad to directly parse environment,
but this isn't a current upstream goal.

So, to provision a comprehensive settings.json through rOPS is probably
better than tweak environment to recreate such a file each container start.

The implementation is straightforward: bypass the entrypoint,
ie don't check anymore if connection works and don't provision a settings.json.

Node so starts directly.

Test Plan

Tested on Equatower

Diff Detail

Repository
rDETHER Docker image for Etherpad
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
production
Build Status
Buildable 2759
Build 3007: arc lint + arc unit

Event Timeline

dereckson created this revision.

Don't provision settings.json at all and so bypass entry point

dereckson retitled this revision from Don't check database at container startup to Don't check database or provision settings at container startup.
dereckson edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sep 19 2018, 09:44
This revision was automatically updated to reflect the committed changes.