Revert "Use hash symbols instead of strings for keys"
ClosedPublic
Actions

Authored by dereckson on Sep 21 2018, 21:48.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 12, 08:18

	Unknown Object (File)
	Sun, May 10, 14:42

	Unknown Object (File)
	Sat, May 9, 12:45

	Unknown Object (File)
	Wed, May 6, 10:05

	Unknown Object (File)
	Mon, May 4, 10:36

	Unknown Object (File)
	Sun, May 3, 19:06

	Unknown Object (File)
	Sun, May 3, 12:47

	Unknown Object (File)
	Sat, May 2, 16:26

View All Files

Subscribers

None

Details

Reviewers

dereckson

Maniphest Tasks

T1449: Tommy doesn't show URL anymore

Commits

rTOMMY6da348fade1a: Revert "Use hash symbols instead of strings for keys"

Summary

Fix a regression where project properties aren't accessible anymore,
and so build URLs aren't included on the dashboard.

This reverts commit 517786ca4886.

Ref T1449

Test Plan

$ bundle exec rackup -o 0.0.0.0 -p 4567
$ curl localhost:4567 | grep ci

Diff Detail

Repository

rTOMMY Tommy

Lint

Lint Passed

Unit

No Test Coverage

Branch

fix-regression-url (branched from master)

Build Status

Buildable 2792
Build 3040: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Sep 21 2018, 21:48

dereckson created this revision.

Harbormaster completed remote builds in B2792: Diff 4564.Sep 21 2018, 21:48

dereckson edited the summary of this revision. (Show Details)Sep 21 2018, 21:49

dereckson accepted this revision.Sep 21 2018, 21:53

This revision is now accepted and ready to land.Sep 21 2018, 21:53

Closed by commit rTOMMY6da348fade1a: Revert "Use hash symbols instead of strings for keys" (authored by dereckson). · Explain WhySep 21 2018, 21:54

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

tommy.rb

6 lines

Diff 4564

View Options

Revert "Use hash symbols instead of strings for keys"ClosedPublicActions