Revert "Use hash symbols instead of strings for keys"
ClosedPublic
Actions

Authored by dereckson on Sep 21 2018, 21:48.

Tags

None

Referenced Files

	F3913261: D1801.id4564.diff
	Thu, Dec 19, 09:08

	F3912766: D1801.diff
	Thu, Dec 19, 06:51

	Unknown Object (File)
	Tue, Dec 17, 11:52

	Unknown Object (File)
	Sun, Dec 15, 15:44

	Unknown Object (File)
	Fri, Dec 13, 22:39

	Unknown Object (File)
	Tue, Dec 10, 21:11

	Unknown Object (File)
	Mon, Dec 9, 04:04

	Unknown Object (File)
	Sun, Dec 8, 08:08

View All Files

Subscribers

None

Details

Reviewers

dereckson

Maniphest Tasks

T1449: Tommy doesn't show URL anymore

Commits

rTOMMY6da348fade1a: Revert "Use hash symbols instead of strings for keys"

Summary

Fix a regression where project properties aren't accessible anymore,
and so build URLs aren't included on the dashboard.

This reverts commit 517786ca4886.

Ref T1449

Test Plan

$ bundle exec rackup -o 0.0.0.0 -p 4567
$ curl localhost:4567 | grep ci

Diff Detail

Repository

rTOMMY Tommy

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Sep 21 2018, 21:48

dereckson created this revision.

Harbormaster completed remote builds in B2792: Diff 4564.Sep 21 2018, 21:48

dereckson edited the summary of this revision. (Show Details)Sep 21 2018, 21:49

dereckson accepted this revision.Sep 21 2018, 21:53

This revision is now accepted and ready to land.Sep 21 2018, 21:53

Closed by commit rTOMMY6da348fade1a: Revert "Use hash symbols instead of strings for keys" (authored by dereckson). · Explain WhySep 21 2018, 21:54

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

tommy.rb

6 lines

Diff 4565

View Options

Revert "Use hash symbols instead of strings for keys"ClosedPublicActions