Page MenuHomeDevCentral

Provide a void Services instance as fallback
ClosedPublic

Authored by dereckson on Jan 9 2016, 04:55.
Tags
None
Referenced Files
F10392920: D196.id.diff
Fri, Jul 4, 02:12
Unknown Object (File)
Thu, Jul 3, 01:09
Unknown Object (File)
Wed, Jul 2, 18:42
Unknown Object (File)
Wed, Jul 2, 14:23
Unknown Object (File)
Sat, Jun 28, 18:29
Unknown Object (File)
Sat, Jun 28, 12:49
Unknown Object (File)
Sat, Jun 28, 11:28
Unknown Object (File)
Fri, Jun 27, 09:49
Subscribers
None

Details

Reviewers
dereckson
Commits
Unknown Object (Diffusion Commit)
rNOTIF343dd7c666c2: Provide a void Services instance as fallback
Summary

The configuration key security.gate.credentials allows to define
a credentials.json file with the list of services credentials.

When the file doesn't exist, instead of deserializing this file,
we provide an empty Services instance.

This fixes a regression introduced at D180.

Test Plan

phpunit

Diff Detail

Repository
rNOTIF Notifications center
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
services-without-config
Build Status
Buildable 247
Build 247: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to Provide a void Services instance as fallback.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson updated this object.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jan 9 2016, 04:58
This revision was automatically updated to reflect the committed changes.