Page MenuHomeDevCentral

Don't accept initial / as container name
ClosedPublic

Authored by dereckson on Oct 10 2018, 23:46.
Tags
None
Referenced Files
F11622341: D1879.id4745.diff
Tue, Sep 2, 07:29
F11616874: D1879.id4746.diff
Mon, Sep 1, 20:09
Unknown Object (File)
Thu, Aug 28, 12:26
Unknown Object (File)
Thu, Aug 28, 11:57
Unknown Object (File)
Sun, Aug 17, 15:53
Unknown Object (File)
Sun, Aug 17, 09:09
Unknown Object (File)
Tue, Aug 12, 10:01
Unknown Object (File)
Mon, Aug 11, 15:26
Subscribers
None

Details

Summary

The Docker registry allows to use /foo or foo as container name.

This is a dubious comfort feature, but it would be nice if queries
like %2Ftmp (/tmp URL encoded) doesn't have a lot of chance to
succeed: even if the API is intended to expose metadata of a
filesystem without any secret, it could theoretically be deployed
into environment where filesystem can expose secrets.

Test Plan

Browse {{URL}}/docker/registry/repository/%2Ftmp/

Diff Detail

Repository
rAPIREG Nasqueron private Docker registry API
Lint
Lint Passed
Unit
No Test Coverage
Branch
master
Build Status
Buildable 2902
Build 3150: arc lint + arc unit

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Oct 10 2018, 23:46
This revision was automatically updated to reflect the committed changes.