Page MenuHomeDevCentral
Differential D1937

Fetch and extract released PHP source code
ClosedPublic
Actions

Authored by dereckson on Oct 16 2018, 23:12.
Tags
None
Referenced Files
F3946090: D1937.diff
Thu, Dec 26, 12:21
Unknown Object (File)
Wed, Dec 18, 04:49
Unknown Object (File)
Wed, Dec 18, 04:26
Unknown Object (File)
Tue, Dec 17, 04:34
Unknown Object (File)
Tue, Dec 17, 02:03
Unknown Object (File)
Sun, Dec 15, 01:48
Unknown Object (File)
Fri, Dec 13, 05:46
Unknown Object (File)
Thu, Dec 12, 22:49
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T1469: Deploy a PHP 5 legacy pool on Ysul
Commits
rOPSd07877e85406: Fetch and extract released PHP source code
Summary

A PHP custom build starts with some source code.

When the build is for a released version, it's as simple as
decompress an archive. Version and hash in pillar.

As Jinja doesn't support dictionary expansion, the pure
Python state renderer is used here, to see if it's viable
to avoid the proliferation of read-pillar execution modules.

Ref T1469

Test Plan

salt-call --local state.sls roles/webserver-legacy/php-builder

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
php5 (branched from master)
Build Status
Buildable 3013
Build 3261: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Oct 16 2018, 23:12
dereckson created this revision.
Harbormaster completed remote builds in B3013: Diff 4895.Oct 16 2018, 23:12
dereckson updated this revision to Diff 4896.Oct 16 2018, 23:16

Remove .sls

Harbormaster completed remote builds in B3014: Diff 4896.Oct 16 2018, 23:16
dereckson updated this revision to Diff 4897.Oct 17 2018, 11:55

Extract an unique set of versions from pillar

Harbormaster completed remote builds in B3015: Diff 4897.Oct 17 2018, 11:55
dereckson retitled this revision from Extract PHP source code from releases to Fetch and extract released PHP source code.Oct 17 2018, 11:55
dereckson updated this revision to Diff 4898.Oct 17 2018, 12:01

More coherent presentation

Harbormaster completed remote builds in B3016: Diff 4898.Oct 17 2018, 12:01
dereckson updated this revision to Diff 4899.Oct 17 2018, 12:08

Hey, jinja doesn't like multiline

Harbormaster completed remote builds in B3017: Diff 4899.Oct 17 2018, 12:08
dereckson updated this revision to Diff 4900.Oct 17 2018, 12:09

Set in php_realase_versions

Harbormaster completed remote builds in B3018: Diff 4900.Oct 17 2018, 12:09
dereckson updated this revision to Diff 4901.Oct 17 2018, 12:16

Fix Python datastructures

Harbormaster completed remote builds in B3019: Diff 4901.Oct 17 2018, 12:16
dereckson updated this revision to Diff 4902.Oct 17 2018, 13:30

Switch to Python renderer

Harbormaster completed remote builds in B3020: Diff 4902.Oct 17 2018, 13:30
dereckson edited the summary of this revision. (Show Details)Oct 17 2018, 13:40
dereckson updated this revision to Diff 4903.Oct 17 2018, 16:22

Extract archives

Harbormaster completed remote builds in B3021: Diff 4903.Oct 17 2018, 16:22
dereckson accepted this revision.Oct 17 2018, 16:22
This revision is now accepted and ready to land.Oct 17 2018, 16:22
dereckson added a comment.Oct 17 2018, 16:32
$ utils/dump-py-state.py roles/webserver-legacy/php-builder/source.sls
/opt/php:
  file.directory:
  - user: builder
/opt/php/archives:
  file.directory:
  - user: builder
/opt/php/archives/php-5.6.38.tar.bz2:
  file.managed:
  - source: http://fr2.php.net/get/php-5.6.38.tar.bz2/from/this/mirror
  - source_hash: d65b231bbdd63be4439ef5ced965cfd63e62983429dbd4dfcfb49981593ebc03
  - user: builder
/opt/php/php56:
  file.directory:
  - user: builder
php_build_php56:
  cmd.run:
  - name: tar xjf /opt/php/archives/php-5.6.38.tar.bz2 --strip-components=1 -C /opt/php/php56
  - user: builder
  - creates: /opt/php/php56/configure.in
Closed by commit rOPSd07877e85406: Fetch and extract released PHP source code (authored by dereckson). · Explain WhyOct 17 2018, 16:33
This revision was automatically updated to reflect the committed changes.
dereckson mentioned this in D1938: Compile and dump a Pure python state file.Oct 17 2018, 16:37
dereckson mentioned this in rOPS840894508216: Compile and dump a Pure python state file.Oct 17 2018, 16:41

Revision Contents
Changeset List

PathSize
pillar/
webserver/
6 lines
roles/
webserver-legacy/
php-builder/
10 lines
34 lines

Diff 4895

View Options

pillar/webserver/sites.sls

Loading...
View Options

roles/webserver-legacy/php-builder/init.sls

Loading...
View Options

roles/webserver-legacy/php-builder/source.sls

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator