Differential D1952

Improve ApiResponse implementation for QueryResult documentation
ClosedPublic
Actions

Authored by dereckson on Oct 23 2018, 00:59.

Tags

None

Referenced Files

	F3794438: D1952.id4937.diff
	Wed, Nov 27, 23:24

	F3793889: D1952.diff
	Wed, Nov 27, 21:43

	Unknown Object (File)
	Fri, Nov 22, 20:30

	Unknown Object (File)
	Mon, Nov 18, 02:53

	Unknown Object (File)
	Mon, Nov 18, 02:21

	Unknown Object (File)
	Wed, Nov 13, 06:27

	Unknown Object (File)
	Wed, Nov 13, 06:06

	Unknown Object (File)
	Sat, Nov 9, 07:58

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rLFa5a06613692f: Improve ApiResponse implementation for QueryResult documentation

Summary

To avoid a too magic method, we explain comprehensively the error codes
through two examples, the current one for SELECT, a new one for INSERT.

The II and III code comments cases were swapped.

Test Plan

no op

Diff Detail

Repository

rLF Limiting Factor

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Oct 23 2018, 00:59

dereckson created this revision.

Harbormaster completed remote builds in B3042: Diff 4936.Oct 23 2018, 00:59

dereckson accepted this revision.Oct 23 2018, 01:00

This revision is now accepted and ready to land.Oct 23 2018, 01:00

Closed by commit rLFa5a06613692f: Improve ApiResponse implementation for QueryResult documentation (authored by dereckson). · Explain WhyOct 23 2018, 01:00

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

api/

replies.rs

34 lines

Diff 4937

View Options

Improve ApiResponse implementation for QueryResult documentationClosedPublicActions