Paths

Table of Contentst

Differential D1957

Craft automatic staging area default commit
ClosedPublic
Actions

Authored by dereckson on Oct 27 2018, 20:41.

Details

Reviewers

dereckson

Maniphest Tasks

T1470: Craft automatic staging area default commits

Commits

rOPS9ef0c0892d12: Craft automatic staging area default commit

Summary

Provide a staging-commit-message command to get a default content
for submodule update commits.

Fixes T1470.

Test Plan

$ git commit -a -m "$(staging-commit-message)"

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Unit

No Test Coverage

Branch

craft-staging-commits (branched from master)

Build Status

Buildable 3048
Build 3296: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Oct 27 2018, 20:41

dereckson created this revision.

Harbormaster completed remote builds in B3048: Diff 4945.Oct 27 2018, 20:41

dereckson edited the test plan for this revision. (Show Details)Oct 27 2018, 20:59

dereckson marked 3 inline comments as done.Oct 27 2018, 21:06

dereckson added inline comments.

roles/saltmaster/software/files/staging-commit-message.py
55	Can be a static method
56	shadows the hash function
roles/saltmaster/software/init.sls
24	Okay, in the repo the file is chmoded 755. But Salt copies by default in 644.

Executable chmod. Improve Python code quality.

Harbormaster completed remote builds in B3049: Diff 4947.Oct 27 2018, 21:07

dereckson accepted this revision.Oct 27 2018, 21:07

This revision is now accepted and ready to land.Oct 27 2018, 21:07

Closed by commit rOPS9ef0c0892d12: Craft automatic staging area default commit (authored by dereckson). · Explain WhyOct 27 2018, 21:07

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

roles/

saltmaster/

software/

files/

staging-commit-message.py

94 lines

init.sls

8 lines

Diff 4945

View Options

roles/saltmaster/software/files/staging-commit-message.py