Paths

Table of Contentst

Differential D230

Fixed issue when credentials.json is not defined in the config
ClosedPublic
Actions

Authored by dereckson on Jan 12 2016, 01:30.

Details

Reviewers

dereckson

Commits

Unknown Object (Diffusion Commit)
rNOTIFffe10b383174: Fixed issue when credentials.json is not defined in the config

Summary

As Storage::has(null) returns true and not false,
an exception were thrown by JsonMapper when the configuration
didn't contain a services.gate.credentials value.

Adding unit tests.

Test Plan

phpunit

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Tests Passed

Branch

services

Event Timeline

dereckson updated this revision to Diff 540.Jan 12 2016, 01:30

dereckson retitled this revision from to Fixed issue when credentials.json is not defined in the config.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/19/ (console: https://ci.nasqueron.org/job/test-notifications-phab/19/console)

dereckson accepted this revision.Jan 12 2016, 01:31

dereckson updated this object.

dereckson edited edge metadata.

dereckson removed a subscriber: alken-orin.

This revision is now accepted and ready to land.Jan 12 2016, 01:32

Closed by commit rNOTIFffe10b383174: Fixed issue when credentials.json is not defined in the config (authored by dereckson, committed by dereckson). · Explain WhyJan 12 2016, 01:32

This revision was automatically updated to reflect the committed changes.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/19/ for more details.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

app/

Providers/

ServicesServiceProvider.php

2 lines

100%

tests/

Providers/

ServicesServiceProviderTest.php

41 lines

Diff 540

View Options

app/Providers/ServicesServiceProvider.php