Differential D2164

Document File::from return value as static
ClosedPublic
Actions

Authored by dereckson on Jan 29 2020, 03:10.

Tags

None

Referenced Files

	F10397806: D2164.diff
	Fri, Jul 4, 15:57

	Unknown Object (File)
	Fri, Jun 27, 15:27

	Unknown Object (File)
	Sat, Jun 21, 23:12

	Unknown Object (File)
	Sat, Jun 21, 07:33

	Unknown Object (File)
	Sat, Jun 21, 04:59

	Unknown Object (File)
	Fri, Jun 20, 22:05

	Unknown Object (File)
	Fri, Jun 20, 22:00

	Unknown Object (File)
	Fri, Jun 20, 20:49

Subscribers

None

Details

Reviewers

Commits

rKOT42911b95f98d: Document File::from return value as static

Summary

This change allows Phan to correctly analyze the methods availability.

This is a follow-up for 7266cfd77f31.

Test Plan

Without the change, Phan outputs:

$ phan
src/Registration/PSR4/Autoloader.php:51 PhanUndeclaredMethod Call to undeclared method \Keruald\OmniTools\IO\File::tryInclude
tests/Reflection/CodeFileTest.php:41 PhanUndeclaredMethod Call to undeclared method \Keruald\OmniTools\IO\File::canBeIncluded

After the change, it doesn't prints these messages.

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Passed

Unit

Test Failures

Branch

master

Build Status

Buildable 3365
Build 3614: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	/usr/home/dereckson/dev/keruald/omnitools/tests/IO/FileTest.php

Event Timeline

dereckson requested review of this revision.Jan 29 2020, 03:10

dereckson created this revision.

Harbormaster completed remote builds in B3365: Diff 5453.Jan 29 2020, 03:10

dereckson accepted this revision.Jan 29 2020, 03:11

This revision is now accepted and ready to land.Jan 29 2020, 03:11

This revision was landed with ongoing or failed builds.Jan 29 2020, 03:11

Closed by commit rKOT42911b95f98d: Document File::from return value as static (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOT42911b95f98d: Document File::from return value as static.

Revision Contents
Changeset List

Path

Size

src/

IO/

3 lines

Diff 5453

src/IO/File.php

Loading...