Differential D233

Fix BrokerFactory issue to provide blackhole broker
ClosedPublic
Actions

Authored by dereckson on Jan 12 2016, 01:59.

Details

Reviewers

dereckson

Commits

rKBROKERd654b8fc95bc: Fix BrokerFactory issue to provide blackhole broker

Summary

The implementation at D225 doesn't contain a check
if the 'omnipotence' key exists in params array.

Test Plan

Run our local and Notifications center tests suites

Diff Detail

Repository

rKBROKER Keruald Broker

Lint

Lint Passed

Unit

Tests Passed

Branch

fix/omnipotence

Build Status

Buildable 292
Build 310: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 546.Jan 12 2016, 01:59

dereckson retitled this revision from to Fix BrokerFactory issue to provide blackhole broker.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Jan 12 2016, 02:00

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jan 12 2016, 02:00

Closed by commit rKBROKERd654b8fc95bc: Fix BrokerFactory issue to provide blackhole broker (authored by dereckson, committed by dereckson). · Explain WhyJan 12 2016, 02:00

This revision was automatically updated to reflect the committed changes.

dereckson added a child revision: D231: Use broker factory.Jan 12 2016, 02:17

dereckson mentioned this in rKBROKER0bce735feb1b: Broker factory.Jan 12 2016, 02:19

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

BlackholeBroker.php

14 lines

50%

Diff 546

View Options

Fix BrokerFactory issue to provide blackhole brokerClosedPublicActions