Paths

Table of Contentst

Ensure tests can run with PHPUnit 9
ClosedPublic
Actions

Authored by dereckson on Mar 10 2020, 18:49.

Tags

None

Referenced Files

	F27251337: D2274.id5729.diff
	Sat, May 2, 02:14

	F27237118: D2274.diff
	Fri, May 1, 21:58

	Unknown Object (File)
	Thu, Apr 30, 12:27

	Unknown Object (File)
	Tue, Apr 28, 18:41

	Unknown Object (File)
	Tue, Apr 14, 23:00

	Unknown Object (File)
	Sun, Apr 12, 23:51

	Unknown Object (File)
	Thu, Apr 2, 23:47

	Unknown Object (File)
	Thu, Apr 2, 15:00

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rKOTdb2a8f4bed7c: Ensure tests can run with PHPUnit 9

Summary

Fixes the following issue:

PHP Fatal error:  Declaration of Keruald\OmniTools\Tests\Strings\Multibyte\OmniStringTest::setUp()
must be compatible with PHPUnit\Framework\TestCase::setUp(): void
in .../keruald/omnitools/tests/Strings/Multibyte/OmniStringTest.php on line 97

Test Plan

phpunit

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Passed

Unit

Tests Skipped

Branch

phpunit-compliance (branched from master)

Build Status

Buildable 3533
Build 3782: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 10 2020, 18:49

dereckson created this revision.

Harbormaster completed remote builds in B3533: Diff 5729.Mar 10 2020, 18:49

dereckson accepted this revision.Mar 10 2020, 18:49

This revision is now accepted and ready to land.Mar 10 2020, 18:49

Closed by commit rKOTdb2a8f4bed7c: Ensure tests can run with PHPUnit 9 (authored by dereckson). · Explain WhyMar 10 2020, 18:56

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOTdb2a8f4bed7c: Ensure tests can run with PHPUnit 9.

Revision Contents
Changeset List

Path

Size

tests/

Strings/

Multibyte/

OmniStringTest.php

2 lines

Diff 5729

View Options

tests/Strings/Multibyte/OmniStringTest.php

Ensure tests can run with PHPUnit 9ClosedPublicActions