Paths

Table of Contentst

Differential D2278

Detect when test suite runs with privileged access
ClosedPublic
Actions

Authored by dereckson on Mar 11 2020, 14:42.

Tags

None

Referenced Files

	F28410034: D2278.id5740.diff
	Tue, May 12, 04:54

	Unknown Object (File)
	Mon, May 11, 19:52

	Unknown Object (File)
	Mon, May 11, 17:13

	Unknown Object (File)
	Sat, May 9, 14:51

	Unknown Object (File)
	Sat, May 9, 06:05

	Unknown Object (File)
	Sat, May 9, 03:37

	Unknown Object (File)
	Sat, May 9, 02:25

	Unknown Object (File)
	Sat, May 9, 01:14

Subscribers

None

Details

Reviewers

Commits

rKOT7292b54afb09: Detect when test suite runs with privileged access

Summary

When the test suite runs as root under Linux or FreeBSD,
or with elevated status ('runs as administrator') on Windows,
the process can see normally non-readable files.

As such, we skip the relevant tests.

Test Plan

Windows: runs in a regular console and a privileged console
Debian: runs as root, and with sudo -u nobody phpunit
FreeBSD: runs trim(shell_exec('id -u')) with psysh

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Errors

Severity	Location	Code	Message
Error	tests/Reflection/CodeFileTest.php:40	PHPCS.E.Generic.WhiteSpace.DisallowTabIndent.TabsUsed	Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Error	tests/Reflection/CodeFileTest.php:65	PHPCS.E.Generic.WhiteSpace.DisallowTabIndent.TabsUsed	Generic.WhiteSpace.DisallowTabIndent.TabsUsed

Unit

Tests Passed

Branch

master

Build Status

Buildable 3537
Build 3786: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 11 2020, 14:42

dereckson created this revision.

Harbormaster completed remote builds in B3537: Diff 5737.Mar 11 2020, 14:42

Tweak and document

Harbormaster completed remote builds in B3538: Diff 5738.Mar 11 2020, 19:27

We can try to use posix too

Harbormaster completed remote builds in B3539: Diff 5739.Mar 11 2020, 19:32

Exceptions, general case

Harbormaster completed remote builds in B3540: Diff 5740.Mar 11 2020, 19:38

dereckson accepted this revision.Mar 11 2020, 19:53

This revision is now accepted and ready to land.Mar 11 2020, 19:53

Closed by commit rKOT7292b54afb09: Detect when test suite runs with privileged access (authored by dereckson). · Explain WhyMar 11 2020, 19:54

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOT7292b54afb09: Detect when test suite runs with privileged access.

Revision Contents
Changeset List

Path

Size

tests/

Reflection/

CodeFileTest.php

26 lines

Diff 5737

tests/Reflection/CodeFileTest.php

Loading...