Switch to OmniString::explode implementation
ClosedPublic
Actions

Authored by dereckson on Mar 16 2020, 01:35.

Tags

None

Referenced Files

	F13404650: D2283.id5753.diff
	Sat, Nov 22, 03:36

	F13403136: D2283.id5754.diff
	Sat, Nov 22, 03:20

	F13395320: D2283.id5754.diff
	Sat, Nov 22, 01:57

	F13390706: D2283.diff
	Sat, Nov 22, 01:10

	F13388656: D2283.id5753.diff
	Sat, Nov 22, 00:46

	Unknown Object (File)
	Tue, Nov 18, 21:37

	Unknown Object (File)
	Tue, Nov 18, 03:51

	Unknown Object (File)
	Sun, Nov 16, 05:29

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rKOT9e4c82e02a41: Switch to OmniString::explode implementation

Summary

230faccc628f has introduced a correct reference implementation
of explode, without any "returns false" surprise if the delimiter
is "".

This change switches OmniArray::explode implementation to use that.

Test Plan

Unit tests provided

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Passed

Unit

Tests Passed

Branch

master

Build Status

Buildable 3548
Build 3797: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 16 2020, 01:35

dereckson created this revision.

Harbormaster completed remote builds in B3548: Diff 5753.Mar 16 2020, 01:35

dereckson accepted this revision.Mar 16 2020, 01:36

dereckson edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Mar 16 2020, 01:36

Closed by commit rKOT9e4c82e02a41: Switch to OmniString::explode implementation (authored by dereckson). · Explain WhyMar 16 2020, 01:37

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOT9e4c82e02a41: Switch to OmniString::explode implementation.

Revision Contents
Changeset List

Path

Size

src/

Collections/

OmniArray.php

6 lines

tests/

Collections/

OmniArrayTest.php

12 lines

Diff 5753

View Options

src/Collections/OmniArray.php