Switch to OmniString::explode implementation
ClosedPublic
Actions

Authored by dereckson on Mar 16 2020, 01:35.

Tags

None

Referenced Files

	F7151740: D2283.diff
	Mon, Apr 21, 13:32

	Unknown Object (File)
	Sun, Apr 20, 11:58

	Unknown Object (File)
	Sun, Apr 20, 10:40

	Unknown Object (File)
	Sun, Apr 20, 04:01

	Unknown Object (File)
	Sat, Apr 19, 14:01

	Unknown Object (File)
	Sat, Apr 19, 06:41

	Unknown Object (File)
	Fri, Apr 18, 17:43

	Unknown Object (File)
	Wed, Apr 16, 13:10

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rKOT9e4c82e02a41: Switch to OmniString::explode implementation

Summary

230faccc628f has introduced a correct reference implementation
of explode, without any "returns false" surprise if the delimiter
is "".

This change switches OmniArray::explode implementation to use that.

Test Plan

Unit tests provided

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Mar 16 2020, 01:35

dereckson created this revision.

Harbormaster completed remote builds in B3548: Diff 5753.Mar 16 2020, 01:35

dereckson accepted this revision.Mar 16 2020, 01:36

dereckson edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Mar 16 2020, 01:36

Closed by commit rKOT9e4c82e02a41: Switch to OmniString::explode implementation (authored by dereckson). · Explain WhyMar 16 2020, 01:37

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOT9e4c82e02a41: Switch to OmniString::explode implementation.

Revision Contents
Changeset List

Path

Size

src/

Collections/

OmniArray.php

6 lines

tests/

Collections/

OmniArrayTest.php

12 lines

Diff 5754

View Options

src/Collections/OmniArray.php