Differential D2372

Fix entrypoint.sh creating one folder named {plugins,embedded-db}
ClosedPublic
Actions

Authored by dereckson on Oct 14 2020, 02:21.

Details

Reviewers

dereckson

Commits

rDOf5f19ab8b0a4: Fix entrypoint.sh creating one folder named {plugins,embedded-db}

Summary

To allow spaces in variables like OPENFIRE_DATA_DIR, they have been enclosed
in quotes.

As the expression uses GNU coreutils mkdir {} syntax, put the {} in quotes
has broken the directory creation: instead to create /path/to/openfire/plugins
and /path/to/openfire/embedded-db, it created the exact quoted content.

That breaks new installations when directories don't exist.

This change fixes that regression. This is a follow-up for e76b3cfd9f47.

Test Plan

$ export OPENFIRE_DATA_DIR=/tmp/openfire
$ mkdir -p "${OPENFIRE_DATA_DIR}"/{plugins,embedded-db}
$ ls $OPENFIRE_DATA_DIR
embedded-db  plugins

Diff Detail

Repository

rDO Docker image for Openfire

Lint

Lint Passed

Unit

No Test Coverage

Branch

fix-mkdir

Build Status

Buildable 3680
Build 3930: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Oct 14 2020, 02:21

dereckson created this revision.

Harbormaster completed remote builds in B3680: Diff 5967.Oct 14 2020, 02:21

Imported from https://github.com/nasqueron/docker-openfire/pull/1

Author: Brandon Delcamp (see commit)

dereckson accepted this revision.Oct 14 2020, 02:23

This revision is now accepted and ready to land.Oct 14 2020, 02:23

Closed by commit rDOf5f19ab8b0a4: Fix entrypoint.sh creating one folder named {plugins,embedded-db} (authored by Brandon Delcamp <delcamp.brandon@gmail.com>, committed by dereckson). · Explain WhyOct 14 2020, 02:26

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rDOf5f19ab8b0a4: Fix entrypoint.sh creating one folder named {plugins,embedded-db}.

Revision Contents
Changeset List

Path

Size

entrypoint.sh

2 lines

Diff 5967

View Options

Fix entrypoint.sh creating one folder named {plugins,embedded-db}ClosedPublicActions