Paths

Table of Contentst

Differential D2406

Define commands as a dictionary instead of a tuple
ClosedPublic
Actions

Authored by dereckson on Sep 4 2021, 20:15.

Details

Reviewers

dereckson

Maniphest Tasks

Unknown Object (Maniphest Task)

Commits

rOPS4509fe3de0a0: Define commands as a dictionary instead of a tuple

Summary

The extraneous comma made commands parsed as a tuple,
not as intended as a dictionary.

This caused any issue to fail the following test:
<command> in commands, as the tuple doesn't have named keys.

Ref T1647.

Test Plan

bats scripts/bats/test_edit_acme_dns_accounts.sh

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Errors

Severity	Location	Code	Message
Error	roles/paas-docker/letsencrypt/files/edit-acme-dns-accounts.py:107	E501	flake8 E501

Unit

No Test Coverage

Branch

fix-tuple-edit-acme-dns-accounts

Build Status

Buildable 3732
Build 3982: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Sep 4 2021, 20:15

dereckson created this revision.

Harbormaster completed remote builds in B3732: Diff 6048.Sep 4 2021, 20:15

dereckson accepted this revision.Sep 4 2021, 20:15

This revision is now accepted and ready to land.Sep 4 2021, 20:15

This revision was landed with ongoing or failed builds.Sep 4 2021, 20:15

Closed by commit rOPS4509fe3de0a0: Define commands as a dictionary instead of a tuple (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOPS4509fe3de0a0: Define commands as a dictionary instead of a tuple.

Revision Contents
Changeset List

Path

Size

roles/

paas-docker/

letsencrypt/

files/

edit-acme-dns-accounts.py

2 lines

Diff 6048

View Options

roles/paas-docker/letsencrypt/files/edit-acme-dns-accounts.py

Define commands as a dictionary instead of a tupleClosedPublicActions