Integration test: 404 for not existing Phabricator door
ClosedPublic
Actions

Authored by dereckson on Jan 21 2016, 01:49.

Details

Reviewers

Commits

Unknown Object (Diffusion Commit)
rNOTIF087c82957076: Integration test: 404 for not existing Phabricator door

Summary

Phabricator doors must be declared in credentials.json. We ensure
if a non existing door is used, a 404 error is returned.

This will achieve full coverage of the PhabricatorGateController.

Test Plan

Run tests

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 584.Jan 21 2016, 01:49

dereckson retitled this revision from to Integration test: 404 for not existing Phabricator door.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/40/ (console: https://ci.nasqueron.org/job/test-notifications-phab/40/console)

Build is green https://ci.nasqueron.org/job/test-notifications-phab/40/ for more details.

Rebased against D250.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/42/ (console: https://ci.nasqueron.org/job/test-notifications-phab/42/console)

Build is green https://ci.nasqueron.org/job/test-notifications-phab/42/ for more details.

dereckson accepted this revision.Jan 23 2016, 00:38

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jan 23 2016, 00:38

Closed by commit rNOTIF087c82957076: Integration test: 404 for not existing Phabricator door (authored by dereckson, committed by dereckson). · Explain WhyJan 23 2016, 00:39

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

tests/

Http/

PayloadFullTest.php

26 lines

Diff 605

View Options

tests/Http/PayloadFullTest.php

Integration test: 404 for not existing Phabricator doorClosedPublicActions