Page MenuHomeDevCentral
Differential D261

GitHubPayloadAnalyzer exception when payload isn't an object
ClosedPublic
Actions

Authored by dereckson on Jan 24 2016, 08:23.
Tags
None
Referenced Files
F3770602: D261.diff
Sat, Nov 23, 20:55
Unknown Object (File)
Mon, Nov 11, 21:33
Unknown Object (File)
Mon, Nov 11, 19:45
Unknown Object (File)
Sun, Nov 10, 04:34
Unknown Object (File)
Thu, Nov 7, 17:16
Unknown Object (File)
Thu, Nov 7, 16:58
Unknown Object (File)
Thu, Nov 7, 14:57
Unknown Object (File)
Thu, Nov 7, 14:38
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Maniphest Tasks
T695: Send a non JSON error to /gate/GitHub should fail sooner
Commits
Unknown Object (Diffusion Commit)
rNOTIF7f5f73b94803: GitHubPayloadAnalyzer exception when payload isn't an object
Summary

GitHubPayloadAnalyzer constructor requires a $payload parameter,
which is the deserialization of the JSON GitHub payload.

The constructor now checks it's indeed an object, or throws an
exception if not.

Test Plan

Fire a Phabricator payload to /gate/GitHub/projectWithoutSecret

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
No Test Coverage
Branch
T695

Event Timeline

dereckson updated this revision to Diff 609.Jan 24 2016, 08:23
dereckson added a task: T695: Send a non JSON error to /gate/GitHub should fail sooner.
dereckson retitled this revision from to GitHubPayloadAnalyzer exception when payload isn't an object.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
alken-orin added a subscriber: alken-orin.Jan 24 2016, 08:23

Build started: https://ci.nasqueron.org/job/test-notifications-phab/52/ (console: https://ci.nasqueron.org/job/test-notifications-phab/52/console)

dereckson accepted this revision.Jan 24 2016, 08:23
dereckson edited the test plan for this revision. (Show Details)
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jan 24 2016, 08:24
Closed by commit rNOTIF7f5f73b94803: GitHubPayloadAnalyzer exception when payload isn't an object (authored by dereckson, committed by dereckson). · Explain WhyJan 24 2016, 08:24
This revision was automatically updated to reflect the committed changes.
alken-orin added a comment.Jan 24 2016, 08:27

Build is green https://ci.nasqueron.org/job/test-notifications-phab/52/ for more details.

Revision Contents
Changeset List

PathSize
app/
Analyzers/
GitHub/
4 lines

Diff 609

View Options

app/Analyzers/GitHub/GitHubPayloadAnalyzer.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator