Page MenuHomeDevCentral

GitHubPayloadAnalyzer exception when payload isn't an object
ClosedPublic

Authored by dereckson on Jan 24 2016, 08:23.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 00:58
Unknown Object (File)
Sat, Nov 23, 22:36
Unknown Object (File)
Sat, Nov 23, 22:29
Unknown Object (File)
Sat, Nov 23, 20:55
Unknown Object (File)
Mon, Nov 11, 21:33
Unknown Object (File)
Mon, Nov 11, 19:45
Unknown Object (File)
Sun, Nov 10, 04:34
Unknown Object (File)
Thu, Nov 7, 17:16
Subscribers

Details

Summary

GitHubPayloadAnalyzer constructor requires a $payload parameter,
which is the deserialization of the JSON GitHub payload.

The constructor now checks it's indeed an object, or throws an
exception if not.

Test Plan

Fire a Phabricator payload to /gate/GitHub/projectWithoutSecret

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson retitled this revision from to GitHubPayloadAnalyzer exception when payload isn't an object.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited the test plan for this revision. (Show Details)
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jan 24 2016, 08:24
This revision was automatically updated to reflect the committed changes.