Page MenuHomeDevCentral
Differential D2481

Ensure array key exists The service entry point can be used outside a web context, for example through CLI to run a MediaWiki maintenance script. As such, we can't make assertions on keys available in the $_SERVER array.
ClosedPublic
Actions

Authored by dereckson on Jan 23 2022, 17:00.
Tags
None
Referenced Files
F27211660: D2481.id6255.diff
Fri, May 1, 11:44
F27210802: D2481.diff
Fri, May 1, 10:37
Unknown Object (File)
Sat, Apr 25, 04:58
Unknown Object (File)
Tue, Apr 21, 17:48
Unknown Object (File)
Sun, Apr 19, 15:26
Unknown Object (File)
Sat, Apr 18, 22:25
Unknown Object (File)
Thu, Apr 16, 05:35
Unknown Object (File)
Tue, Apr 14, 17:01
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T1675: Fix deprecation introduced by PHP 7.4 and PHP 8
Commits
rSAASSVC223248b07ad9: Ensure array key exists
Summary

Ref T1675

Test Plan

sudo -u mediawiki mw update agora

Diff Detail

Repository
rSAASSVC SaaS base entry point
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
master
Build Status
Buildable 3868
Build 4119: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Jan 23 2022, 17:00
dereckson created this revision.
Harbormaster completed remote builds in B3868: Diff 6254.Jan 23 2022, 17:00
dereckson accepted this revision.Jan 23 2022, 17:00
This revision is now accepted and ready to land.Jan 23 2022, 17:00
Closed by commit rSAASSVC223248b07ad9: Ensure array key exists (authored by dereckson). · Explain WhyJan 23 2022, 17:02
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rSAASSVC223248b07ad9: Ensure array key exists.

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 6254

View Options

src/Service.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator