Use $this binding in closures
ClosedPublic
Actions

Authored by dereckson on Jan 26 2022, 20:42.

Tags

None

Referenced Files

	F24705038: D2490.diff
	Fri, Mar 6, 09:27

	F24705033: D2490.diff
	Fri, Mar 6, 09:27

	F24699972: D2490.diff
	Fri, Mar 6, 03:44

	Unknown Object (File)
	Wed, Mar 4, 07:57

	Unknown Object (File)
	Sun, Mar 1, 01:25

	Unknown Object (File)
	Mon, Feb 23, 21:37

	Unknown Object (File)
	Thu, Feb 12, 20:20

	Unknown Object (File)
	Thu, Feb 12, 16:48

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rKOT49ac85a4696e: Use $this binding in closures

Summary

With the automatic binding of $this, $that = $this isn't needed in PHP.

Test Plan

tests/Registration still succeed

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Skipped

Unit

Tests Skipped

Branch

main

Build Status

Buildable 3879
Build 4130: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Jan 26 2022, 20:42

dereckson created this revision.

Harbormaster completed remote builds in B3879: Diff 6274.Jan 26 2022, 20:42

Where we learn PHP isn't JavaScript.

This revision is now accepted and ready to land.Jan 26 2022, 20:43

Closed by commit rKOT49ac85a4696e: Use $this binding in closures (authored by dereckson). · Explain WhyJan 26 2022, 20:44

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOT49ac85a4696e: Use $this binding in closures.

Revision Contents
Changeset List

Path

Size

src/

Registration/

PSR4/

Autoloader.php

6 lines

Diff 6274

View Options

src/Registration/PSR4/Autoloader.php

Use $this binding in closuresClosedPublicActions